Merge pull request #14590 from guardian/tf-gate-popup

Update sign-in gate treatmentType

Author: tomrf1

dotcom-rendering/src/components/SignInGate/types.ts

@@ -98,9 +98,13 @@ export interface TreatmentContentDecoded {
 	second_cta_name?: string;
 }
 
+// The treatmentType is how Auxia tells the client which type of gate to display
+// The spelling of "dismissible" is inconsistent here, but this is because the treatments were set up this way in Auxia.
 export type AuxiaAPIResponseDataUserTreatmentType =
 	| 'DISMISSABLE_SIGN_IN_GATE'
-	| 'NONDISMISSIBLE_SIGN_IN_GATE';
+	| 'NONDISMISSIBLE_SIGN_IN_GATE'
+	| 'DISMISSABLE_SIGN_IN_GATE_POPUP'
+	| 'NONDISMISSIBLE_SIGN_IN_GATE_POPUP';
 
 export interface AuxiaAPIResponseDataUserTreatment {
 	treatmentId: string;

dotcom-rendering/src/components/SignInGateSelector.importable.tsx

@@ -258,7 +258,7 @@ export const getAuxiaGateVersion = (
 		String(version).toLowerCase().endsWith('v2') ||
 		String(userTreatment?.treatmentType)
 			.toLowerCase()
-			.includes('v2')
+			.endsWith('POPUP')
 	) {
 		return 'v2';
 	}