Skip to content

Commit e123eac

Browse files
committed
use main riff-raff for ab-testing ui deploy
1 parent f9bfc9c commit e123eac

File tree

5 files changed

+20
-57
lines changed

5 files changed

+20
-57
lines changed
Lines changed: 2 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,6 @@
11
name: 🦕 AB testing UI
22
on:
3-
pull_request:
4-
paths:
5-
- 'ab-testing/**'
6-
push:
7-
branches:
8-
- main
9-
paths:
10-
- 'ab-testing/**'
3+
workflow_call:
114

125
jobs:
136
build-ui:
@@ -32,41 +25,6 @@ jobs:
3225
- name: Save build
3326
uses: actions/[email protected]
3427
with:
35-
name: ui-build
28+
name: ab-testing-ui-build
3629
path: ${{ github.workspace }}/ab-testing/frontend/output/ab-tests.html
3730
if-no-files-found: error
38-
39-
riff-raff:
40-
name: AB testing Riffraff upload
41-
runs-on: ubuntu-latest
42-
permissions:
43-
id-token: write
44-
contents: read
45-
pull-requests: write
46-
47-
steps:
48-
- name: Checkout
49-
uses: actions/checkout@v5
50-
with:
51-
fetch-depth: 0
52-
persist-credentials: false
53-
54-
- name: Set up Node
55-
uses: ./.github/actions/setup-node-env
56-
57-
- name: Fetch build
58-
uses: actions/[email protected]
59-
with:
60-
name: ui-build
61-
path: output/ab-tests.html
62-
63-
- name: Riff-Raff Upload
64-
uses: guardian/[email protected]
65-
with:
66-
roleArn: ${{ secrets.GU_RIFF_RAFF_ROLE_ARN }}
67-
githubToken: ${{ secrets.GITHUB_TOKEN }}
68-
projectName: dotcom:rendering-all
69-
configPath: ab-testing/riff-raff.yaml
70-
contentDirectories: |
71-
frontend-store/commercial:
72-
- output/ab-tests.html

.github/workflows/cicd.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@ jobs:
2626
with:
2727
container-image: ${{ needs.container.outputs.container-image }}
2828

29+
ab-testing-ui:
30+
needs: [container, prettier, jest, lint, playwright]
31+
uses: ./.github/workflows/ab-testing-ui.yml
32+
2933
publish:
3034
permissions:
3135
id-token: write

.github/workflows/publish.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,11 @@ jobs:
5353
rm -r interactive-rendering/*
5454
mv interactive-rendering.tar.gz interactive-rendering/
5555
56+
- name: Get AB Testing build
57+
uses: actions/[email protected]
58+
with:
59+
name: ui-build
60+
5661
# All rendering apps deployment
5762
- name: Upload rendering apps to RiffRaff
5863
uses: guardian/[email protected]
@@ -80,3 +85,5 @@ jobs:
8085
- interactive-rendering
8186
frontend-static:
8287
- frontend-static
88+
frontend-store/admin:
89+
- ab-testing/frontend/output/ab-tests.html

ab-testing/riff-raff.yaml

Lines changed: 0 additions & 13 deletions
This file was deleted.

dotcom-rendering/scripts/deploy/riff-raff.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,13 @@ deployments:
2626
value: public, max-age=315360000, immutable # one year in seconds
2727
prefixStack: false
2828
publicReadAcl: false
29+
frontend-store/admin:
30+
type: aws-s3
31+
parameters:
32+
bucketSsmKey: /account/services/dotcom-store.bucket
33+
cacheControl: public, max-age=315360000
34+
prefixStack: false
35+
publicReadAcl: false
2936
# article-rendering cloudformation
3037
article-rendering-cfn:
3138
template: cloudformation

0 commit comments

Comments
 (0)