Skip to content

Commit e5dfa94

Browse files
committed
Create Opinion No Avatar experiment
1 parent e329505 commit e5dfa94

File tree

3 files changed

+14
-51
lines changed

3 files changed

+14
-51
lines changed

dotcom-rendering/src/components/DecideContainer.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ type Props = {
4848
frontId?: string;
4949
collectionId: number;
5050
containerLevel?: DCRContainerLevel;
51-
isInNoBoostsAbTestVariant?: boolean;
51+
isInOpinionNoAvatarVariant?: boolean;
5252
};
5353

5454
export const DecideContainer = ({
@@ -64,7 +64,7 @@ export const DecideContainer = ({
6464
frontId,
6565
collectionId,
6666
containerLevel,
67-
isInNoBoostsAbTestVariant,
67+
isInOpinionNoAvatarVariant,
6868
}: Props) => {
6969
switch (containerType) {
7070
case 'dynamic/fast':
@@ -270,7 +270,7 @@ export const DecideContainer = ({
270270
aspectRatio={aspectRatio}
271271
containerLevel={containerLevel}
272272
collectionId={collectionId}
273-
isInNoBoostsAbTestVariant={isInNoBoostsAbTestVariant}
273+
isInOpinionNoAvatarVariant={isInOpinionNoAvatarVariant}
274274
/>
275275
);
276276
case 'scrollable/small':

dotcom-rendering/src/components/FlexibleGeneral.tsx

Lines changed: 6 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import type { ResponsiveFontSize } from './CardHeadline';
2121
import type { Loading } from './CardPicture';
2222
import { FeatureCard } from './FeatureCard';
2323
import { FrontCard } from './FrontCard';
24-
import { Hide } from './Hide';
2524
import type { Alignment } from './SupportingContent';
2625

2726
type Props = {
@@ -33,7 +32,7 @@ type Props = {
3332
aspectRatio: AspectRatio;
3433
containerLevel?: DCRContainerLevel;
3534
collectionId: number;
36-
isInNoBoostsAbTestVariant?: boolean;
35+
isInOpinionNoAvatarVariant?: boolean;
3736
};
3837

3938
type RowLayout = 'oneCardHalfWidth' | 'oneCardFullWidth' | 'twoCard';
@@ -582,7 +581,7 @@ export const FlexibleGeneral = ({
582581
aspectRatio,
583582
containerLevel = 'Primary',
584583
collectionId,
585-
isInNoBoostsAbTestVariant,
584+
isInOpinionNoAvatarVariant,
586585
}: Props) => {
587586
const splash = [...groupedTrails.splash].slice(0, 1).map((snap) => ({
588587
...snap,
@@ -594,6 +593,9 @@ export const FlexibleGeneral = ({
594593
.map((standard, i) => ({
595594
...standard,
596595
uniqueId: `collection-${collectionId}-standard-${i}`,
596+
avatarUrl: isInOpinionNoAvatarVariant
597+
? undefined
598+
: standard.avatarUrl,
597599
}));
598600

599601
const groupedCards = decideCardPositions(cards);
@@ -616,48 +618,7 @@ export const FlexibleGeneral = ({
616618
{groupedCards.map((row, i) => {
617619
switch (row.layout) {
618620
case 'oneCardFullWidth':
619-
return isInNoBoostsAbTestVariant ? (
620-
<>
621-
<Hide when="above" breakpoint="tablet">
622-
<HalfWidthCardLayout
623-
key={row.cards[0]?.uniqueId}
624-
cards={row.cards}
625-
containerPalette={containerPalette}
626-
showAge={showAge}
627-
absoluteServerTimes={
628-
absoluteServerTimes
629-
}
630-
imageLoading={imageLoading}
631-
isFirstRow={!splash.length && i === 0}
632-
isFirstStandardRow={i === 0}
633-
aspectRatio={aspectRatio}
634-
isLastRow={
635-
i === groupedCards.length - 1
636-
}
637-
containerLevel={containerLevel}
638-
/>
639-
</Hide>
640-
<Hide when="below" breakpoint="tablet">
641-
<FullWidthCardLayout
642-
key={row.cards[0]?.uniqueId}
643-
cards={row.cards}
644-
containerPalette={containerPalette}
645-
showAge={showAge}
646-
absoluteServerTimes={
647-
absoluteServerTimes
648-
}
649-
imageLoading={imageLoading}
650-
aspectRatio={aspectRatio}
651-
isFirstRow={!splash.length && i === 0}
652-
isLastRow={
653-
i === groupedCards.length - 1
654-
}
655-
containerLevel={containerLevel}
656-
collectionId={collectionId}
657-
/>
658-
</Hide>
659-
</>
660-
) : (
621+
return (
661622
<FullWidthCardLayout
662623
key={row.cards[0]?.uniqueId}
663624
cards={row.cards}

dotcom-rendering/src/layouts/FrontLayout.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,8 @@ export const FrontLayout = ({ front, NAV }: Props) => {
136136

137137
const { absoluteServerTimes = false } = front.config.switches;
138138

139-
const isInNoBoostsVariant = abTests.noBoostsVariant === 'variant';
139+
const isInOpinionNoAvatarVariant =
140+
abTests.opinionNoAvatarVariant === 'variant' && front.isNetworkFront;
140141

141142
const fallbackAspectRatio = (collectionType: DCRContainerType) => {
142143
switch (collectionType) {
@@ -636,8 +637,9 @@ export const FrontLayout = ({ front, NAV }: Props) => {
636637
sectionId={ophanName}
637638
collectionId={index + 1}
638639
containerLevel={collection.containerLevel}
639-
isInNoBoostsAbTestVariant={
640-
pageId === 'uk' && isInNoBoostsVariant
640+
isInOpinionNoAvatarVariant={
641+
collection.displayName === 'Opinion' &&
642+
isInOpinionNoAvatarVariant
641643
}
642644
/>
643645
</FrontSection>

0 commit comments

Comments
 (0)