Skip to content

Commit e70089f

Browse files
author
Juarez Mota
committed
feat: add data attributes for testing and styling in AuthProviderButtons and SignInGate components
1 parent f111a2e commit e70089f

File tree

3 files changed

+18
-3
lines changed

3 files changed

+18
-3
lines changed

dotcom-rendering/src/components/AuthProviderButtons/AuthProviderButtons.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,8 @@ const SocialButton = ({
9494
onClick={() => onClick?.(socialProvider as AuthButtonProvider)}
9595
data-cy={`${socialProvider}-sign-in-button`}
9696
data-link-name={`${socialProvider}-social-button`}
97+
data-testid="sign-in-gate-main_signin"
98+
data-ignore="global-link-styling"
9799
>
98100
{authProviderButtonLabel(label)}
99101
</LinkButton>
@@ -171,6 +173,8 @@ export const AuthProviderButtons = ({
171173
queryParams,
172174
)}
173175
onClick={() => onClick?.('email')}
176+
data-testid="sign-in-gate-main_signin"
177+
data-ignore="global-link-styling"
174178
>
175179
{authProviderButtonLabel('email')}
176180
</LinkButton>

dotcom-rendering/src/components/SignInGate/gateDesigns/SignInGateAuxiaV1.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import { InformationBox } from '../../InformationBox/InformationBox';
1717
import { GuardianTerms } from '../../Terms/Terms';
1818
import { trackLink } from '../componentEventTracking';
1919
import type { SignInGatePropsAuxia, TreatmentContentDecoded } from '../types';
20-
import { signInGateContainer } from './shared';
20+
import { hideElementsCss, signInGateContainer } from './shared';
2121

2222
const DividerWithOr = () => {
2323
return (
@@ -56,12 +56,15 @@ export const SignInGateAuxiaV1 = ({
5656

5757
return (
5858
<div css={signInGateContainer} data-testid="sign-in-gate-main">
59+
<style>{hideElementsCss}</style>
5960
<div css={topBar}>
6061
<SvgGuardianLogo textColor="#041F4A" width={96} />
6162

6263
{isDismissible && (
6364
<button
6465
type="button"
66+
data-testid="sign-in-gate-main_dismiss"
67+
data-ignore="global-link-styling"
6568
css={dismissButtonStyles}
6669
onClick={() => {
6770
dismissGate();
@@ -147,6 +150,8 @@ export const SignInGateAuxiaV1 = ({
147150
'REGISTER-LINK',
148151
);
149152
}}
153+
data-testid="sign-in-gate-main_register"
154+
data-ignore="global-link-styling"
150155
>
151156
{firstCtaName}
152157
</ExternalLink>

dotcom-rendering/src/components/Terms/Terms.tsx

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,17 @@ import { InformationBoxText } from '../InformationBox/InformationBox';
44
export const GuardianTerms = () => (
55
<InformationBoxText>
66
By proceeding, you agree to our{' '}
7-
<ExternalLink href="https://www.theguardian.com/help/terms-of-service">
7+
<ExternalLink
8+
href="https://www.theguardian.com/help/terms-of-service"
9+
data-ignore="global-link-styling"
10+
>
811
terms and conditions
912
</ExternalLink>
1013
. For information about how we use your data, see our{' '}
11-
<ExternalLink href="https://www.theguardian.com/help/privacy-policy">
14+
<ExternalLink
15+
href="https://www.theguardian.com/help/privacy-policy"
16+
data-ignore="global-link-styling"
17+
>
1218
privacy policy
1319
</ExternalLink>
1420
.

0 commit comments

Comments
 (0)