Skip to content

Commit e95cb0f

Browse files
author
sookburt
committed
rename DesignableBannerV2 to DesignableBanner across the board, duplicate import in ReaderRevenueBanner till fixed in SDC
1 parent 322c77c commit e95cb0f

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

dotcom-rendering/src/components/StickyBottomBanner/ReaderRevenueBanner.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -312,9 +312,9 @@ export const ReaderRevenueBanner = ({
312312
import(`../marketing/banners/signInPrompt/SignInPromptBanner`)
313313
: name === 'DesignableBannerV2'
314314
? /* webpackChunkName: "designable-banner-v2" */
315-
import(`../marketing/banners/designableBanner/DesignableBannerV2`)
315+
import(`../marketing/banners/designableBanner/DesignableBanner`)
316316
: /* webpackChunkName: "designable-banner" */
317-
import(`../marketing/banners/designableBanner/DesignableBannerV2`)
317+
import(`../marketing/banners/designableBanner/DesignableBanner`)
318318
)
319319
.then((bannerModule: { [key: string]: React.ElementType }) => {
320320
setBanner(() => bannerModule[name] ?? null);

dotcom-rendering/src/components/marketing/banners/designableBanner/DesignableBannerV2.tsx renamed to dotcom-rendering/src/components/marketing/banners/designableBanner/DesignableBanner.tsx

File renamed without changes.

dotcom-rendering/src/components/marketing/banners/designableBanner/stories/DesignableBannerV2.stories.tsx renamed to dotcom-rendering/src/components/marketing/banners/designableBanner/stories/DesignableBanner.stories.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import type {
55
} from '@guardian/support-dotcom-components/dist/shared/types';
66
import type { Meta, StoryObj } from '@storybook/react';
77
import lzstring from 'lz-string';
8-
import { DesignableBannerUnvalidatedV2 as DesignableBannerV2 } from '../../../banners/designableBanner/DesignableBannerV2';
98
import { choiceCardsSettings } from '../../../lib/storybook';
109
import {
1110
contentNoHeading,
@@ -15,12 +14,13 @@ import {
1514
stringToHexColour,
1615
tracking,
1716
} from '../../utils/storybook';
17+
import { DesignableBannerUnvalidated as DesignableBanner } from '../DesignableBanner';
1818

1919
type WithJsonProps<T> = T & { json?: string };
20-
type Props = WithJsonProps<React.ComponentProps<typeof DesignableBannerV2>>;
20+
type Props = WithJsonProps<React.ComponentProps<typeof DesignableBanner>>;
2121
const meta: Meta<Props> = {
22-
component: DesignableBannerV2,
23-
title: 'Components/marketing/DesignableBannerV2',
22+
component: DesignableBanner,
23+
title: 'Components/marketing/DesignableBanner',
2424
args: {
2525
...props,
2626
json: '',
@@ -32,7 +32,7 @@ const meta: Meta<Props> = {
3232

3333
return (
3434
<div>
35-
<DesignableBannerV2 {...args} {...jsonProps} />
35+
<DesignableBanner {...args} {...jsonProps} />
3636
</div>
3737
);
3838
},
@@ -41,7 +41,7 @@ export default meta;
4141

4242
type Story = StoryObj<Props>;
4343
export const Default: Story = {
44-
name: 'Basic DesignableBannerV2',
44+
name: 'Basic DesignableBanner',
4545
};
4646

4747
const regularChoiceCardAmounts: SelectedAmountsVariant = {
@@ -194,7 +194,7 @@ export const MainImage: Story = {
194194
};
195195

196196
export const DesignThreeAnimatedHeaderImage: Story = {
197-
name: 'DesignableBanner with animated header image',
197+
name: 'With animated header image',
198198
args: {
199199
...meta.args,
200200
content: contentNoHeading,

0 commit comments

Comments
 (0)