Skip to content

Commit ecf3982

Browse files
Merge pull request #13839 from guardian/lp-update-sdc-6.2.0
Update SDC to 6.2.0
2 parents 6abd398 + e355613 commit ecf3982

File tree

8 files changed

+9
-58
lines changed

8 files changed

+9
-58
lines changed

dotcom-rendering/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
"@guardian/shimport": "1.0.2",
5555
"@guardian/source": "9.0.0",
5656
"@guardian/source-development-kitchen": "17.0.0",
57-
"@guardian/support-dotcom-components": "6.1.0",
57+
"@guardian/support-dotcom-components": "6.2.0",
5858
"@guardian/tsconfig": "0.2.0",
5959
"@playwright/test": "1.45.3",
6060
"@sentry/browser": "7.75.1",

dotcom-rendering/src/components/marketing/banners/designableBanner/stories/DesignableBanner.stories.tsx

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,7 @@
33
* This file was migrated from:
44
* https://github.com/guardian/support-dotcom-components/blob/0a2439b701586a7a2cc60dce10b4d96cf7a828db/packages/modules/src/modules/banners/designableBanner/stories/DesignableBanner.stories.tsx
55
*/
6-
import {
7-
SecondaryCtaType,
8-
TickerCountType,
9-
TickerEndType,
10-
} from '@guardian/support-dotcom-components';
6+
import { SecondaryCtaType } from '@guardian/support-dotcom-components';
117
import type {
128
BannerDesignImage,
139
SelectedAmountsVariant,
@@ -55,13 +51,9 @@ export const Default: Story = {
5551
};
5652

5753
const tickerSettings: TickerSettings = {
58-
endType: TickerEndType.unlimited,
59-
countType: TickerCountType.money,
6054
currencySymbol: '£',
6155
copy: {
6256
countLabel: '',
63-
goalReachedPrimary: '',
64-
goalReachedSecondary: '',
6557
},
6658
tickerData: {
6759
total: 500000,

dotcom-rendering/src/components/marketing/epics/ContributionsEpic.stories.tsx

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,7 @@
44
* https://github.com/guardian/support-dotcom-components/blob/a482b35a25ca59f66501c4de02de817046206298/packages/modules/src/modules/epics/ContributionsEpic.stories.tsx
55
*/
66
import { css } from '@emotion/react';
7-
import {
8-
SecondaryCtaType,
9-
TickerCountType,
10-
TickerEndType,
11-
} from '@guardian/support-dotcom-components';
7+
import { SecondaryCtaType } from '@guardian/support-dotcom-components';
128
import type { Meta, StoryObj } from '@storybook/react';
139
import lzstring from 'lz-string';
1410
import React from 'react';
@@ -198,13 +194,9 @@ export const WithTicker: Story = {
198194
variant: {
199195
...props.variant,
200196
tickerSettings: {
201-
endType: TickerEndType.unlimited,
202-
countType: TickerCountType.money,
203197
currencySymbol: '£',
204198
copy: {
205199
countLabel: 'Help us reach our end-of-year goal',
206-
goalReachedPrimary: '',
207-
goalReachedSecondary: '',
208200
},
209201
tickerData: {
210202
total: 10000,
@@ -226,13 +218,9 @@ export const WithTickerAndWithAboveTopReaderArticleCount: Story = {
226218
type: 'above',
227219
},
228220
tickerSettings: {
229-
endType: TickerEndType.unlimited,
230-
countType: TickerCountType.money,
231221
currencySymbol: '£',
232222
copy: {
233223
countLabel: 'Help us reach our end-of-year goal',
234-
goalReachedPrimary: '',
235-
goalReachedSecondary: '',
236224
},
237225
tickerData: {
238226
total: 10000,

dotcom-rendering/src/components/marketing/epics/ContributionsEpic.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,6 @@ const ContributionsEpic: ReactComponent<EpicProps> = ({
263263
tracking,
264264
countryCode,
265265
articleCounts,
266-
onReminderOpen,
267266
fetchEmail,
268267
submitComponentEvent,
269268
openCmp,
@@ -419,7 +418,6 @@ const ContributionsEpic: ReactComponent<EpicProps> = ({
419418
tracking={tracking}
420419
countryCode={countryCode}
421420
articleCounts={articleCounts}
422-
onReminderOpen={onReminderOpen}
423421
fetchEmail={fetchEmail}
424422
submitComponentEvent={submitComponentEvent}
425423
amountsTestName={choiceCardAmounts?.testName}

dotcom-rendering/src/components/marketing/epics/ContributionsLiveblogEpic.stories.tsx

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,7 @@
33
* This file was migrated from:
44
* https://github.com/guardian/support-dotcom-components/blob/9c3eae7cb0b159db4a1c40679d6b37710b0bb937/packages/modules/src/modules/epics/ContributionsLiveblogEpic.stories.tsx
55
*/
6-
import {
7-
SecondaryCtaType,
8-
TickerCountType,
9-
TickerEndType,
10-
} from '@guardian/support-dotcom-components';
6+
import { SecondaryCtaType } from '@guardian/support-dotcom-components';
117
import type { Meta, StoryObj } from '@storybook/react';
128
import lzstring from 'lz-string';
139
import React from 'react';
@@ -114,13 +110,9 @@ export const WithTicker: Story = {
114110
secondaryCta: undefined,
115111
showChoiceCards: true,
116112
tickerSettings: {
117-
endType: TickerEndType.unlimited,
118-
countType: TickerCountType.money,
119113
currencySymbol: '£',
120114
copy: {
121115
countLabel: 'Help us reach our end-of-year goal',
122-
goalReachedPrimary: '',
123-
goalReachedSecondary: '',
124116
},
125117
tickerData: {
126118
total: 10000,

dotcom-rendering/src/components/marketing/epics/ContributionsLiveblogEpic.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,6 @@ export const ContributionsLiveblogEpic: ReactComponent<EpicProps> = ({
140140
articleCounts,
141141
tracking,
142142
submitComponentEvent,
143-
onReminderOpen,
144143
fetchEmail,
145144
}: EpicProps): JSX.Element => {
146145
const { newsletterSignup, tickerSettings } = variant;
@@ -221,7 +220,6 @@ export const ContributionsLiveblogEpic: ReactComponent<EpicProps> = ({
221220
tracking={tracking}
222221
countryCode={countryCode}
223222
articleCounts={articleCounts}
224-
onReminderOpen={onReminderOpen}
225223
fetchEmail={fetchEmail}
226224
submitComponentEvent={submitComponentEvent}
227225
/>

dotcom-rendering/src/components/marketing/epics/ctas/ContributionsEpicCtasContainer.tsx

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,6 @@ import type { SupportTier } from '../utils/threeTierChoiceCardAmounts';
77
import { ContributionsEpicButtons } from './ContributionsEpicButtons';
88
import { ContributionsEpicReminder } from './ContributionsEpicReminder';
99

10-
interface OnReminderOpen {
11-
buttonCopyAsString: string;
12-
}
13-
1410
type Props = EpicProps & {
1511
amountsTestName?: string;
1612
amountsVariantName?: string;
@@ -23,7 +19,6 @@ export const ContributionsEpicCtasContainer: ReactComponent<Props> = ({
2319
articleCounts,
2420
tracking,
2521
submitComponentEvent,
26-
onReminderOpen,
2722
fetchEmail,
2823
amountsTestName,
2924
amountsVariantName,
@@ -87,18 +82,6 @@ export const ContributionsEpicCtasContainer: ReactComponent<Props> = ({
8782
tracking={tracking}
8883
countryCode={countryCode}
8984
onOpenReminderClick={(): void => {
90-
const buttonCopyAsString = showReminderFields?.reminderCta
91-
.toLowerCase()
92-
.replace(/\s/g, '-');
93-
94-
// This callback lets the platform react to the user interaction with the
95-
// 'Remind me' button
96-
if (onReminderOpen) {
97-
onReminderOpen({
98-
buttonCopyAsString,
99-
} as OnReminderOpen);
100-
}
101-
10285
if (fetchEmail) {
10386
void fetchEmail().then((resolvedEmail) => {
10487
if (resolvedEmail) {

pnpm-lock.yaml

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)