Follow prefer-promise-reject-errors lint rule (#14693)

This rule comes from `typescript-eslint`:
https://typescript-eslint.io/rules/prefer-promise-reject-errors/

We don't have it enabled yet, but in v8 it's part of the
"recommended-type-checked" preset:
https://typescript-eslint.io/blog/announcing-typescript-eslint-v8/#updated-configuration-rules

In order to keep the upgrade to that version as small as possible, this
change pre-emptively fixes code considered incorrect by that rule. It
creates `Error` objects for instances where we have control over the
value the `Promise` is rejecting with, and disables the rule in cases
where we don't have control over this value because it comes from a
library.

Another approach would be to create our own `Error` object and include
the unknown library error using the `cause` option, but the browser
support is not good enough for that yet:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/Error#cause

Author: JamieB-gu

dotcom-rendering/src/client/userFeatures/user-features.ts

@@ -30,6 +30,7 @@ const refresh = async (): Promise<void> => {
 const requestNewData = async () => {
 	const authStatus = await getAuthStatus();
 	if (authStatus.kind !== 'SignedIn') {
+		// eslint-disable-next-line @typescript-eslint/prefer-promise-reject-errors
 		return Promise.reject('The user is not signed in');
 	}
 	return syncDataFromUserBenefitsApi(authStatus).then(persistResponse);

dotcom-rendering/src/components/LightboxJavascript.tsx

@@ -66,7 +66,7 @@ const timeout = <T,>(promise: Promise<T>, delay = 1200) =>
 		promise,
 		new Promise<void>((_, reject) => {
 			const timer = setTimeout(() => {
-				reject();
+				reject(new Error());
 				clearTimeout(timer);
 			}, delay);
 		}),

dotcom-rendering/src/components/YoutubeAtom/YoutubePlayer.ts

@@ -143,6 +143,9 @@ class YouTubePlayer {
 					}
 				} catch (e) {
 					this.logError(e as Error);
+					/* eslint-disable-next-line @typescript-eslint/prefer-promise-reject-errors --
+					 * This object comes from the YT API; we can't enforce that
+					 * it's an instance of Error. */
 					reject(e);
 				}
 			},

dotcom-rendering/src/lib/braze/hasRequiredConsents.ts

@@ -6,6 +6,9 @@ const hasRequiredConsents = (): Promise<boolean> =>
 			try {
 				resolve(getConsentFor('braze', state));
 			} catch (e) {
+				/* eslint-disable-next-line @typescript-eslint/prefer-promise-reject-errors --
+				 * This object comes from guardian/libs; we can't enforce in
+				 * DCAR that it's an instance of Error. */
 				reject(e);
 			}
 		});