fix: simplify onCloseClick condition for Maybe Later variant in DesignableBanner

Juarez Mota · Juarez Mota · commit eec8473a5fdc · 2025-09-04T11:10:07.000+01:00
diff --git a/dotcom-rendering/src/components/marketing/banners/designableBanner/DesignableBanner.tsx b/dotcom-rendering/src/components/marketing/banners/designableBanner/DesignableBanner.tsx
@@ -428,9 +428,7 @@ const DesignableBanner: ReactComponent<BannerRenderProps> = ({
 									templateSettings.secondaryCtaSettings
 								}
 								onCloseClick={
-									isMaybeLaterVariant &&
-									isCollapsed &&
-									typeof onCloseClick === 'function'
+									isMaybeLaterVariant && isCollapsed
 										? onCloseClick
 										: undefined
 								}

Original file line number	Diff line number	Diff line change
`@@ -428,9 +428,7 @@ const DesignableBanner: ReactComponent<BannerRenderProps> = ({`
`428`	`428`	`templateSettings.secondaryCtaSettings`
`429`	`429`	`}`
`430`	`430`	`onCloseClick={`
`431`		`- isMaybeLaterVariant &&`
`432`		`- isCollapsed &&`
`433`		`- typeof onCloseClick === 'function'`
	`431`	`+ isMaybeLaterVariant && isCollapsed`
`434`	`432`	`? onCloseClick`
`435`	`433`	`: undefined`
`436`	`434`	`}`