eliminate possibility of race condition for new ab-testing

Author: Jakeii

dotcom-rendering/src/client/abTesting.ts

@@ -29,18 +29,19 @@ const getClientParticipations = (): ABParticipations => {
 
 	return {};
 };
-const initABTesting = (): void => {
-	const { serverSideABTests } = window.guardian.config;
-
-	const clientSideABTests = getClientParticipations();
 
-	const participations = {
-		...clientSideABTests,
-		...serverSideABTests,
+const getABTestParticipations = (): ABParticipations => {
+	return {
+		...getClientParticipations(),
+		...window.guardian.config.serverSideABTests,
 	};
+};
+
+const initABTesting = (): void => {
+	const participations = getABTestParticipations();
 
 	window.guardian.modules.abTests = {
-		getParticipations: () => participations,
+		getParticipations: getABTestParticipations,
 		isUserInTest: (testId: string) => {
 			return !isUndefined(participations[testId]);
 		},
@@ -50,4 +51,4 @@ const initABTesting = (): void => {
 	};
 };
 
-export { initABTesting };
+export { initABTesting, getABTestParticipations };

dotcom-rendering/src/experiments/lib/beta-ab-tests.ts

@@ -1,4 +1,5 @@
 import { isUndefined } from '@guardian/libs';
+import { getABTestParticipations } from '../../client/abTesting';
 
 export interface BetaABTestAPI {
 	getParticipations: () => ABParticipations;
@@ -55,8 +56,7 @@ export class BetaABTests implements BetaABTestAPI {
 		if (isServer) {
 			this.participations = serverSideABTests;
 		} else {
-			this.participations =
-				window.guardian.modules.abTests?.getParticipations() ?? {};
+			this.participations = getABTestParticipations();
 		}
 	}