Skip to content

Commit ef9eba9

Browse files
authored
Merge pull request #14971 from guardian/doml/fix-feature-card-video
Fix Feature card Youtube video stories
2 parents 4a39283 + c6dfb21 commit ef9eba9

File tree

1 file changed

+58
-56
lines changed

1 file changed

+58
-56
lines changed

dotcom-rendering/src/components/FeatureCard.stories.tsx

Lines changed: 58 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,9 @@ export default meta;
112112

113113
type Story = StoryObj<typeof meta>;
114114

115-
export const Standard: Story = {};
115+
export const Standard = {} satisfies Story;
116116

117-
export const Immersive: Story = {
117+
export const Immersive = {
118118
args: {
119119
aspectRatio: '5:3',
120120
mobileAspectRatio: '4:5',
@@ -124,9 +124,9 @@ export const Immersive: Story = {
124124
trailText:
125125
'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua',
126126
},
127-
};
127+
} satisfies Story;
128128

129-
export const Labs: Story = {
129+
export const Labs = {
130130
args: {
131131
byline: undefined,
132132
format: {
@@ -158,17 +158,17 @@ export const Labs: Story = {
158158
},
159159
showLabsRedesign: true,
160160
},
161-
};
161+
} satisfies Story;
162162

163-
export const LabsImmersive: Story = {
163+
export const LabsImmersive = {
164164
args: {
165165
...Labs.args,
166166
...Immersive.args,
167167
trailText: undefined,
168168
},
169-
};
169+
} satisfies Story;
170170

171-
export const Review: Story = {
171+
export const Review = {
172172
args: {
173173
image: {
174174
src: 'https://media.guim.co.uk/59b7005b3ee36fcdf1215e4424fa6d141a805e3a/0_236_1365_1705/master/1365.jpg',
@@ -180,16 +180,16 @@ export const Review: Story = {
180180
'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.',
181181
starRating: 3,
182182
},
183-
};
183+
} satisfies Story;
184184

185-
export const ReviewImmersive: Story = {
185+
export const ReviewImmersive = {
186186
args: {
187187
...Review.args,
188188
...Immersive.args,
189189
},
190-
};
190+
} satisfies Story;
191191

192-
export const SportLiveBlog: Story = {
192+
export const SportLiveBlog = {
193193
args: {
194194
image: {
195195
src: 'https://media.guim.co.uk/e9a9adba2ba6a984317eeb42ad0ef5dfbee0ed1d/0_229_4972_2984/master/4972.jpg',
@@ -203,16 +203,16 @@ export const SportLiveBlog: Story = {
203203
showPulsingDot: true,
204204
showClock: true,
205205
},
206-
};
206+
} satisfies Story;
207207

208-
export const SportLiveBlogImmersive: Story = {
208+
export const SportLiveBlogImmersive = {
209209
args: {
210210
...SportLiveBlog.args,
211211
...Immersive.args,
212212
},
213-
};
213+
} satisfies Story;
214214

215-
export const Opinion: Story = {
215+
export const Opinion = {
216216
args: {
217217
image: {
218218
src: 'https://media.guim.co.uk/e07c6b2dbd2332b89744e0548dc10f5b2dfa58e2/0_2482_6767_4058/master/6767.jpg',
@@ -221,16 +221,16 @@ export const Opinion: Story = {
221221
showQuotes: true,
222222
format: { ...cardProps.format, theme: Pillar.Opinion },
223223
},
224-
};
224+
} satisfies Story;
225225

226-
export const OpinionImmersive: Story = {
226+
export const OpinionImmersive = {
227227
args: {
228228
...Opinion.args,
229229
...Immersive.args,
230230
},
231-
};
231+
} satisfies Story;
232232

233-
export const Podcast: Story = {
233+
export const Podcast = {
234234
args: {
235235
format: {
236236
...cardProps.format,
@@ -249,16 +249,16 @@ export const Podcast: Story = {
249249
duration: '55:09',
250250
},
251251
},
252-
};
252+
} satisfies Story;
253253

254-
export const PodcastImmersive: Story = {
254+
export const PodcastImmersive = {
255255
args: {
256256
...Podcast.args,
257257
...Immersive.args,
258258
},
259-
};
259+
} satisfies Story;
260260

261-
export const Gallery: Story = {
261+
export const Gallery = {
262262
args: {
263263
format: {
264264
...cardProps.format,
@@ -273,17 +273,19 @@ export const Gallery: Story = {
273273
count: '12',
274274
},
275275
},
276-
};
276+
} satisfies Story;
277277

278-
export const GalleryImmersive: Story = {
278+
export const GalleryImmersive = {
279279
args: {
280280
...Gallery.args,
281281
...Immersive.args,
282282
},
283-
};
283+
} satisfies Story;
284284

285-
// A video article
286-
export const Video: Story = {
285+
/**
286+
* A video article
287+
*/
288+
export const YoutubeVideo = {
287289
args: {
288290
format: {
289291
...cardProps.format,
@@ -303,41 +305,41 @@ export const Video: Story = {
303305
title: 'Video Title',
304306
duration: 120,
305307
expired: false,
306-
image: 'https://media.guim.co.uk/video-thumbnail.jpg',
308+
image: 'https://media.guim.co.uk/f2aedd24e5414073a653f68112e0ad070c6f4a2b/254_0_7493_4500/master/7493.jpg',
307309
},
310+
canPlayInline: true,
311+
showVideo: true,
308312
},
309-
};
313+
} satisfies Story;
310314

311-
export const VideoImmersive: Story = {
315+
export const YoutubeVideoImmersive = {
312316
args: {
313-
...Video.args,
317+
...YoutubeVideo.args,
314318
...Immersive.args,
315319
},
316-
};
320+
} satisfies Story;
317321

318-
// A standard (non-video) article with a video main media
319-
export const VideoMainMedia: Story = {
322+
/**
323+
* A standard (non-video) article with a video main media
324+
*/
325+
export const YoutubeVideoMainMedia = {
320326
args: {
321-
...Video.args,
322-
image: {
323-
src: 'https://media.guim.co.uk/4612af5f4667888fa697139cf570b6373d93a710/2446_345_3218_1931/master/3218.jpg',
324-
altText: 'alt text',
325-
},
327+
...YoutubeVideo.args,
326328
format: {
327-
...cardProps.format,
329+
...YoutubeVideo.args.format,
328330
design: ArticleDesign.Standard,
329331
},
330332
},
331-
};
333+
} satisfies Story;
332334

333-
export const VideoMainMediaImmersive: Story = {
335+
export const YoutubeVideoMainMediaImmersive = {
334336
args: {
335-
...VideoMainMedia.args,
337+
...YoutubeVideoMainMedia.args,
336338
...Immersive.args,
337339
},
338-
};
340+
} satisfies Story;
339341

340-
export const WithTrailText: Story = {
342+
export const WithTrailText = {
341343
args: {
342344
kickerText: undefined,
343345
headlineText: 'Nigel Slater’s recipe for coffee cream liqueur trifle',
@@ -350,32 +352,32 @@ export const WithTrailText: Story = {
350352
trailText:
351353
'Part trifle, part tiramisu… this midweek treat ticks all the right boxes',
352354
},
353-
};
355+
} satisfies Story;
354356

355-
export const WithTrailTextImmersive: Story = {
357+
export const WithTrailTextImmersive = {
356358
args: {
357359
...WithTrailText.args,
358360
...Immersive.args,
359361
},
360-
};
362+
} satisfies Story;
361363

362-
export const WithSublinks: Story = {
364+
export const WithSublinks = {
363365
args: {
364366
supportingContent,
365367
},
366-
};
368+
} satisfies Story;
367369

368-
export const WithSublinksImmersive: Story = {
370+
export const WithSublinksImmersive = {
369371
args: {
370372
...WithSublinks.args,
371373
...Immersive.args,
372374
},
373-
};
375+
} satisfies Story;
374376

375-
export const WithSublinksLabsImmersive: Story = {
377+
export const WithSublinksLabsImmersive = {
376378
args: {
377379
...WithSublinks.args,
378380
...Labs.args,
379381
...Immersive.args,
380382
},
381-
};
383+
} satisfies Story;

0 commit comments

Comments
 (0)