Skip to content

Commit f282a60

Browse files
sookburtsookburt
andauthored
Tidy unused DesignableBanner code (#14141)
* capture animated header story * move ThreeTierChoiceCards from epic to shared directory * export under both names till can rename * identify unused banner components as step towards removal * identify unused banner component * identify unused another banner component * mark as unused, highlight potential keeper sections * also notice this is not used anywhere - marked as unused * flag more unused * move interface to more uesful place before deleting otherwise unused file * delete unused code * move headline css override into component and use source typography equivalent * embed separate margins into existing, remove style lint issues * fix mobile headline size * rename DesignableBannerCtasV2 to DesignableBannerCtas and fix import * delete files for PaymentCards and useReminders as unused * remove cssoverride for close button as unused * remove extra headline bottom border to fix chromatic changes * reduce top margin on headline if image exists to fix chromatic error * reduce top margin on headline if image exists to fix chromatic error one more time * rename DesignableBannerV2 to DesignableBanner across the board, duplicate import in ReaderRevenueBanner till fixed in SDC --------- Co-authored-by: sookburt <“[email protected]”>
1 parent 39b4feb commit f282a60

21 files changed

+565
-2956
lines changed

dotcom-rendering/src/components/StickyBottomBanner/ReaderRevenueBanner.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ export const ReaderRevenueBanner = ({
312312
import(`../marketing/banners/signInPrompt/SignInPromptBanner`)
313313
: name === 'DesignableBannerV2'
314314
? /* webpackChunkName: "designable-banner-v2" */
315-
import(`../marketing/banners/designableBanner/DesignableBannerV2`)
315+
import(`../marketing/banners/designableBanner/DesignableBanner`)
316316
: /* webpackChunkName: "designable-banner" */
317317
import(`../marketing/banners/designableBanner/DesignableBanner`)
318318
)

dotcom-rendering/src/components/marketing/banners/ThreeTierChoiceCardsV2.tsx

Lines changed: 0 additions & 148 deletions
This file was deleted.

dotcom-rendering/src/components/marketing/banners/common/PaymentCards.tsx

Lines changed: 0 additions & 211 deletions
This file was deleted.

0 commit comments

Comments
 (0)