Skip to content

Commit f9cf0f7

Browse files
committed
2-step banner: hide ticker + image when collapsed
1 parent ad3b3c9 commit f9cf0f7

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

dotcom-rendering/src/components/marketing/banners/designableBanner/DesignableBanner.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,6 +355,7 @@ const DesignableBanner: ReactComponent<BannerRenderProps> = ({
355355
</div>
356356
)}
357357
{tickerSettings?.tickerData &&
358+
!isCollapsed &&
358359
templateSettings.tickerStylingSettings && (
359360
<div css={templateSpacing.bannerTicker}>
360361
<Ticker
@@ -389,7 +390,7 @@ const DesignableBanner: ReactComponent<BannerRenderProps> = ({
389390
)}
390391
</div>
391392

392-
{templateSettings.imageSettings && (
393+
{templateSettings.imageSettings && !isCollapsed && (
393394
<div css={styles.bannerVisualContainer}>
394395
<DesignableBannerVisual
395396
settings={templateSettings.imageSettings}

dotcom-rendering/src/components/marketing/banners/designableBanner/stories/DesignableBanner.stories.tsx

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -357,5 +357,21 @@ export const CollapsableWithThreeTierChoiceCards: Story = {
357357
},
358358
choiceCardAmounts: regularChoiceCardAmounts,
359359
choiceCardsSettings,
360+
tickerSettings,
361+
},
362+
};
363+
364+
export const CollapsableWithMainImage: Story = {
365+
name: 'Collapsable with main image',
366+
args: {
367+
...meta.args,
368+
design: {
369+
...design,
370+
visual: regularImage,
371+
},
372+
tracking: {
373+
...tracking,
374+
abTestVariant: 'COLLAPSABLE_V1',
375+
},
360376
},
361377
};

0 commit comments

Comments
 (0)