Skip to content

Commit fcf967d

Browse files
Merge pull request #15064 from guardian/a11y-aria-labels
Add aria-labels to buttons for WCAG 4.1.2 compliance
2 parents 385f943 + 530658a commit fcf967d

File tree

5 files changed

+10
-1
lines changed

5 files changed

+10
-1
lines changed

dotcom-rendering/src/components/AudioAtom/AudioAtom.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -349,6 +349,7 @@ export const AudioAtom = ({
349349
data-testid={isPlaying ? 'pause-button' : 'play-button'}
350350
onClick={() => (isPlaying ? pauseAudio() : playAudio())}
351351
css={buttonStyle}
352+
aria-label={isPlaying ? 'Pause' : 'Play'}
352353
>
353354
{isPlaying ? <PauseSVG /> : <PlaySVG />}
354355
</button>

dotcom-rendering/src/components/EditionSwitcherBanner.importable.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ export const EditionSwitcherBanner = ({ pageId, edition }: Props) => {
108108
type="button"
109109
css={closeButton}
110110
data-link-name="edition-switcher-banner close-banner"
111+
aria-label="Close banner"
111112
onClick={() => {
112113
hideEditionSwitcherBanner();
113114
}}

dotcom-rendering/src/components/SignInGate/gateDesigns/SignInGateAuxiaV1.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ export const SignInGateAuxiaV1 = ({
6767
data-testid="sign-in-gate-main_dismiss"
6868
data-ignore="global-link-styling"
6969
css={dismissButtonStyles}
70+
aria-label="Dismiss sign-in gate"
7071
onClick={() => {
7172
dismissGate();
7273
trackLink(

dotcom-rendering/src/components/SignInGate/gateDesigns/SignInGateAuxiaV2.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ export const SignInGateAuxiaV2 = ({
144144
data-testid="sign-in-gate-main_dismiss"
145145
data-ignore="global-link-styling"
146146
css={dismissButtonStyles}
147+
aria-label="Dismiss sign-in gate"
147148
onClick={() => {
148149
dismissGate();
149150
trackLink(
@@ -189,6 +190,7 @@ export const SignInGateAuxiaV2 = ({
189190
data-testid="sign-in-gate-main_dismiss"
190191
data-ignore="global-link-styling"
191192
css={signInDismissButtonStyles}
193+
aria-label="Dismiss sign-in gate"
192194
onClick={() => {
193195
dismissGate();
194196
trackLink(

dotcom-rendering/src/components/marketing/banners/designableBanner/DesignableBanner.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -449,7 +449,11 @@ const DesignableBanner: ReactComponent<BannerRenderProps> = ({
449449
'secondary',
450450
)}
451451
hideLabel={true}
452-
/>
452+
>
453+
{isCollapsed
454+
? 'Expand banner'
455+
: 'Collapse banner'}
456+
</Button>
453457
</div>
454458
)}
455459
{!isCollapsableBanner && (

0 commit comments

Comments
 (0)