Skip to content

Commit ff5910a

Browse files
Use data-ad-slot attribute to identify ad slots on both web and apps (#14126)
Co-authored-by: Jonathon Herbert <[email protected]>
1 parent 87ecae2 commit ff5910a

File tree

2 files changed

+24
-18
lines changed

2 files changed

+24
-18
lines changed

dotcom-rendering/src/components/AdSlot.apps.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ const adSlotStyles = css`
4646
* the native layer, for it to "paint" an advert over the top of it.
4747
*/
4848
export const AdSlot = forwardRef<HTMLDivElement>((_, ref) => (
49-
<aside css={styles}>
49+
<aside data-ad-slot={true} css={styles}>
5050
<div css={adLabelsStyles}>
5151
<p>Advertisement</p>
5252
</div>

dotcom-rendering/src/components/AdSlot.web.tsx

Lines changed: 23 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,11 @@ const AdSlotWrapper = ({
417417
className?: string;
418418
}) => {
419419
return (
420-
<aside className={`ad-slot-container ${className}`} css={additionalCss}>
420+
<aside
421+
data-ad-slot={true}
422+
className={`ad-slot-container ${className}`}
423+
css={additionalCss}
424+
>
421425
{children}
422426
</aside>
423427
);
@@ -729,22 +733,24 @@ export const AdSlot = ({
729733
}
730734
case 'survey': {
731735
return (
732-
<div
733-
id="dfp-ad--survey"
734-
className={[
735-
'js-ad-slot',
736-
'ad-slot',
737-
'ad-slot--survey',
738-
].join(' ')}
739-
css={[outOfPageStyles, hideBelowDesktop]}
740-
data-link-name="ad slot survey"
741-
data-name="survey"
742-
data-label="false"
743-
data-refresh="false"
744-
data-out-of-page="true"
745-
data-testid="slot"
746-
aria-hidden="true"
747-
/>
736+
<AdSlotWrapper>
737+
<div
738+
id="dfp-ad--survey"
739+
className={[
740+
'js-ad-slot',
741+
'ad-slot',
742+
'ad-slot--survey',
743+
].join(' ')}
744+
css={[outOfPageStyles, hideBelowDesktop]}
745+
data-link-name="ad slot survey"
746+
data-name="survey"
747+
data-label="false"
748+
data-refresh="false"
749+
data-out-of-page="true"
750+
data-testid="slot"
751+
aria-hidden="true"
752+
/>
753+
</AdSlotWrapper>
748754
);
749755
}
750756
case 'liveblog-inline': {

0 commit comments

Comments
 (0)