Skip to content

Commit ffb00f2

Browse files
Merge branch 'main' into mob/inline-product-card
2 parents cc09e59 + d00dfb7 commit ffb00f2

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+1869
-1360
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,6 @@
2424
/dotcom-rendering/src/components/AdP* @guardian/commercial-dev
2525
/dotcom-rendering/src/components/marketing/ @guardian/growth
2626
/dotcom-rendering/src/server/ @guardian/dotcom-platform
27+
/dotcom-rendering/src/lib/braze/ @guardian/value
2728
/dotcom-rendering/webpack/ @guardian/dotcom-platform
2829
/scripts/ @guardian/dotcom-platform

.github/workflows/ab-testing-deploy-prod.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ permissions:
55

66
on:
77
workflow_dispatch:
8-
# push:
9-
# branches:
10-
# - main
11-
# paths:
12-
# - 'ab-testing/**'
8+
push:
9+
branches:
10+
- main
11+
paths:
12+
- 'ab-testing/**'
1313

1414
jobs:
1515
ci:

.github/workflows/ab-testing-ui.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@ on:
33
pull_request:
44
paths:
55
- 'ab-testing/**'
6+
push:
7+
branches:
8+
- main
9+
paths:
10+
- 'ab-testing/**'
611

712
jobs:
813
build-ui:

ab-testing/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ Add your AB tests to the `abTests` array in the `abTest.ts` file. Each test shou
1616
expirationDate: '2050-12-30',
1717
type: 'client',
1818
audienceSize: 10 / 100,
19-
audienceSpace: 'A',
2019
groups: ['control', 'variant'],
20+
shouldForceMetricsCollection: true
2121
}
2222
```
2323

ab-testing/abTest.ts

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -19,30 +19,4 @@ import type { ABTest } from './types';
1919
* - 100% Test variant MVT 500-999
2020
*/
2121

22-
export const ABTests: ABTest[] = [
23-
// Sample tests that will be used for testing the AB testing framework
24-
{
25-
name: 'commercial-client-side-test-1',
26-
description:
27-
'Show new ad block ask component in ad slots when we detect ad blocker usage',
28-
owners: ['[email protected]'],
29-
status: 'ON',
30-
expirationDate: '2050-12-30',
31-
type: 'client',
32-
audienceSize: 10 / 100,
33-
groups: ['control', 'variant'],
34-
shouldForceMetricsCollection: true,
35-
},
36-
{
37-
name: 'commercial-server-side-test-1',
38-
description:
39-
'Show new ad block ask component in ad slots when we detect ad blocker usage',
40-
owners: ['[email protected]'],
41-
status: 'ON',
42-
expirationDate: '2050-12-30',
43-
type: 'server',
44-
audienceSize: 10 / 100,
45-
groups: ['control', 'variant'],
46-
shouldForceMetricsCollection: true,
47-
},
48-
];
22+
export const ABTests: ABTest[] = [];

0 commit comments

Comments
 (0)