Skip to content

Add navigation arrows to product carousel. #15025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
oliverabrahams wants to merge 2 commits into
base: mob/scrollable-products
Choose a base branch
from
Open

Add navigation arrows to product carousel. #15025

oliverabrahams wants to merge 2 commits into from
+148 −26

Conversation

@oliverabrahams
Copy link
Contributor

@oliverabrahams oliverabrahams commented Dec 17, 2025 •
edited
Loading

What does this change?

Adds a Heading and navigation arrows to the product carousel.
Adds an interaction story to to the carousel storybook.

builds off this PR #14968

Screenshots

Screenshot 2025-12-17 at 12 25 21 Screenshot 2025-12-17 at 12 29 07

@oliverabrahams oliverabrahams marked this pull request as ready for review December 17, 2025 14:23
@github-actions
Copy link

github-actions bot commented Dec 17, 2025

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@github-actions
Copy link

github-actions bot commented Dec 17, 2025 •
edited
Loading

Deploy build 23783 of dotcom:rendering-all to CODE

All deployment options

From guardian/actions-riff-raff.

@oliverabrahams oliverabrahams force-pushed the mob/scrollable-products branch from f20853d to a064393 Compare December 19, 2025 17:09
@github-actions
Copy link

github-actions bot commented Dec 22, 2025 •
edited
Loading

Deploy build 445 of dotcom:ab-testing to CODE

All deployment options

From guardian/actions-riff-raff.

@oliverabrahams oliverabrahams mentioned this pull request Dec 22, 2025
Open
@charleycampbell
Copy link
Contributor

charleycampbell commented Jan 6, 2026

Looks good! Have we tested this for accessibility e.g. keyboard navigation etc?

@oliverabrahams oliverabrahams added feature Departmental tracking: work on a new feature run_chromatic Runs chromatic when label is applied labels Jan 15, 2026
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jan 15, 2026
@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Jan 15, 2026
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jan 15, 2026
@oliverabrahams
Copy link
Contributor Author

oliverabrahams commented Jan 16, 2026

Looks good! Have we tested this for accessibility e.g. keyboard navigation etc?

I have tried keyboard navigation and it all seems to work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charleycampbell charleycampbell charleycampbell left review comments

Assignees

No one assigned

Labels

feature Departmental tracking: work on a new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oliverabrahams @charleycampbell