-
Notifications
You must be signed in to change notification settings - Fork 30
Add stacked horizontal product cards component #15095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
| <div css={informationContainer}> | ||
| <div | ||
| css={productCardHeading} | ||
| dangerouslySetInnerHTML={{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come we were able to remove this? Is it to do with the extractHeadingText?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep exactly! We're able to do this because we're not passing in html any more, because of using extractHeadingText.
charleycampbell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just one question but it's just out of curiosity than a blocker!
| `, | ||
| ]} | ||
| > | ||
| <button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use this component from the DS here? https://guardian.github.io/storybooks/?path=/docs/source_react-components-buttonlink--docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we haven't used the DS for the read more using the link but we should look into changing that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will have a look at using it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also could we add tracking to these clicks
What does this change?
Adds a new
StackedCardscomponent, using the Horizontal Product Summary Card.Why?
As another variant for our At a Glance A/B/C test.
Screenshots