Skip to content

Commit 7c302db

Browse files
chore: Upgrade to Scala 3 (#594)
* chore: Upgrade to Scala 3 * build: Cross-compile configTools for Scala 3 and Scala 2.13 * chore: Update scalafmt configuration to use Scala 3 dialect
1 parent 903c2b6 commit 7c302db

File tree

11 files changed

+321
-285
lines changed

11 files changed

+321
-285
lines changed

.scalafmt.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
version = 3.9.3
2-
runner.dialect = scala213
2+
runner.dialect = scala3

app/controllers/Audit.scala

Lines changed: 60 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,13 @@ import aws.AuditTrailDB
44
import com.gu.googleauth.AuthAction
55
import com.gu.janus.model.JanusData
66
import logic.Date
7+
import play.api.mvc.{
8+
AbstractController,
9+
Action,
10+
AnyContent,
11+
ControllerComponents
12+
}
713
import play.api.{Logging, Mode}
8-
import play.api.mvc.{AbstractController, AnyContent, ControllerComponents}
914
import software.amazon.awssdk.services.dynamodb.DynamoDbClient
1015

1116
class Audit(
@@ -16,63 +21,67 @@ class Audit(
1621
extends AbstractController(controllerComponents)
1722
with Logging {
1823

19-
def byAccount(account: String) = authAction { implicit request =>
20-
val date = request.getQueryString(
21-
"date"
22-
) flatMap Date.parseUtcDateStr getOrElse Date.todayUtc
23-
val (startDate, endDate) = Date.weekAround(date)
24-
logger.info(s"Getting logs for $account from $startDate to $endDate")
25-
val auditLogs = AuditTrailDB.getAccountLogs(account, startDate, endDate)
26-
val prevNextWeeks = Date.prevNextAuditWeeks(date)
27-
Ok(
28-
views.html.audit(
29-
auditLogs,
30-
Right(account),
31-
startDate,
32-
prevNextWeeks,
33-
request.user,
34-
janusData
24+
def byAccount(account: String): Action[AnyContent] = authAction {
25+
implicit request =>
26+
val date = request.getQueryString(
27+
"date"
28+
) flatMap Date.parseUtcDateStr getOrElse Date.todayUtc
29+
val (startDate, endDate) = Date.weekAround(date)
30+
logger.info(s"Getting logs for $account from $startDate to $endDate")
31+
val auditLogs = AuditTrailDB.getAccountLogs(account, startDate, endDate)
32+
val prevNextWeeks = Date.prevNextAuditWeeks(date)
33+
Ok(
34+
views.html.audit(
35+
auditLogs,
36+
Right(account),
37+
startDate,
38+
prevNextWeeks,
39+
request.user,
40+
janusData
41+
)
3542
)
36-
)
3743
}
3844

39-
def byUser(username: String) = authAction { implicit request =>
40-
val date = request.getQueryString(
41-
"date"
42-
) flatMap Date.parseUtcDateStr getOrElse Date.todayUtc
43-
val (startDate, endDate) = Date.weekAround(date)
44-
logger.info(s"Getting logs for $username from $startDate to $endDate")
45-
val auditLogs = AuditTrailDB.getUserLogs(username, startDate, endDate)
46-
val prevNextWeeks = Date.prevNextAuditWeeks(date)
47-
Ok(
48-
views.html.audit(
49-
auditLogs,
50-
Left(username),
51-
startDate,
52-
prevNextWeeks,
53-
request.user,
54-
janusData
45+
def byUser(username: String): Action[AnyContent] = authAction {
46+
implicit request =>
47+
val date = request.getQueryString(
48+
"date"
49+
) flatMap Date.parseUtcDateStr getOrElse Date.todayUtc
50+
val (startDate, endDate) = Date.weekAround(date)
51+
logger.info(s"Getting logs for $username from $startDate to $endDate")
52+
val auditLogs = AuditTrailDB.getUserLogs(username, startDate, endDate)
53+
val prevNextWeeks = Date.prevNextAuditWeeks(date)
54+
Ok(
55+
views.html.audit(
56+
auditLogs,
57+
Left(username),
58+
startDate,
59+
prevNextWeeks,
60+
request.user,
61+
janusData
62+
)
5563
)
56-
)
5764
}
5865

59-
def changeUserDate(username: String) = authAction { implicit request =>
60-
val logDateStrOpt = for {
61-
submission <- request.body.asFormUrlEncoded
62-
logDateSubmission <- submission.get("audit-date")
63-
logDateStr <- logDateSubmission.headOption
64-
} yield logDateStr
65-
val param = logDateStrOpt.fold("")(s => s"?date=$s")
66-
SeeOther(s"/audit/user/$username$param")
66+
def changeUserDate(username: String): Action[AnyContent] = authAction {
67+
implicit request =>
68+
val logDateStrOpt = for {
69+
submission <- request.body.asFormUrlEncoded
70+
logDateSubmission <- submission.get("audit-date")
71+
logDateStr <- logDateSubmission.headOption
72+
} yield logDateStr
73+
val param = logDateStrOpt.fold("")(s => s"?date=$s")
74+
SeeOther(s"/audit/user/$username$param")
6775
}
6876

69-
def changeAccountDate(account: String) = authAction { implicit request =>
70-
val logDateStrOpt = for {
71-
submission <- request.body.asFormUrlEncoded
72-
logDateSubmission <- submission.get("audit-date")
73-
logDateStr <- logDateSubmission.headOption
74-
} yield logDateStr
75-
val param = logDateStrOpt.fold("")(s => s"?date=$s")
76-
SeeOther(s"/audit/account/$account$param")
77+
def changeAccountDate(account: String): Action[AnyContent] = authAction {
78+
implicit request =>
79+
val logDateStrOpt = for {
80+
submission <- request.body.asFormUrlEncoded
81+
logDateSubmission <- submission.get("audit-date")
82+
logDateStr <- logDateSubmission.headOption
83+
} yield logDateStr
84+
val param = logDateStrOpt.fold("")(s => s"?date=$s")
85+
SeeOther(s"/audit/account/$account$param")
7786
}
7887
}

app/controllers/AuthController.scala

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import com.gu.googleauth.{GoogleAuthConfig, GoogleGroupChecker, LoginSupport}
44
import com.gu.janus.model.JanusData
55
import play.api.Mode
66
import play.api.libs.ws.WSClient
7-
import play.api.mvc._
7+
import play.api.mvc.*
88

99
import scala.concurrent.ExecutionContext
1010

@@ -25,21 +25,21 @@ class AuthController(
2525
override val failureRedirectTarget: Call = routes.AuthController.loginError
2626
override val defaultRedirectTarget: Call = routes.Janus.index
2727

28-
def login = Action.async { implicit request =>
28+
def login: Action[AnyContent] = Action.async { implicit request =>
2929
startGoogleLogin()
3030
}
3131

32-
def loginError = Action { implicit request =>
32+
def loginError: Action[AnyContent] = Action { implicit request =>
3333
val error =
3434
request.flash.get("error").getOrElse("There was an error logging in")
3535
Ok(views.html.error(error, None, janusData))
3636
}
3737

38-
def logout = Action { implicit request =>
38+
def logout: Action[AnyContent] = Action { implicit request =>
3939
Redirect(routes.Janus.index).withNewSession
4040
}
4141

42-
def oauthCallback = Action.async { implicit request =>
42+
def oauthCallback: Action[AnyContent] = Action.async { implicit request =>
4343
processOauth2Callback(requiredGoogleGroups, googleGroupChecker)
4444
}
4545
}

0 commit comments

Comments
 (0)