Clarifications and fixes (#1293)

* Ensure GutterPayload is in dotcom

* Add type safety when building campaign code

* Add changeset

---------

Co-authored-by: Sue Burt <“sue.burt@guardian.co.uk”>

Author: sookburt

.changeset/early-cups-fetch.md

@@ -0,0 +1,5 @@
+---
+'@guardian/support-dotcom-components': patch
+---
+
+add missing export and further type safety

src/dotcom/types.ts

@@ -3,6 +3,7 @@ export {
     EpicPayload,
     HeaderPayload,
     WeeklyArticleHistory,
+    GutterPayload,
 } from '../shared/types/targeting';
 export * from '../shared/types/prices';
 export { EpicProps } from '../shared/types/props/epic';

src/server/api/gutterRouter.ts

@@ -52,7 +52,7 @@ export const buildGutterRouter = (
             const testTracking: TestTracking = {
                 abTestName: test.name,
                 abTestVariant: variant.name,
-                campaignCode: buildGutterCampaignCode(test.name, variant.name),
+                campaignCode: buildGutterCampaignCode(test, variant),
                 componentType: 'ACQUISITIONS_OTHER', // TODO: TBC - ACQUISITIONS_GUTTER? Changes will need to be made to the Ophan pipeline.
             };
 

src/server/lib/tracking.ts

@@ -1,4 +1,11 @@
-import { BannerTest, BannerVariant, EpicTest, EpicVariant } from '../../shared/types';
+import {
+    BannerTest,
+    BannerVariant,
+    EpicTest,
+    EpicVariant,
+    GutterTest,
+    GutterVariant,
+} from '../../shared/types';
 
 const campaignPrefix = 'gdnwb_copts_memco';
 
@@ -11,8 +18,8 @@ export const buildBannerCampaignCode = (test: BannerTest, variant: BannerVariant
 export const buildAmpEpicCampaignCode = (testName: string, variantName: string): string =>
     `AMP__${testName}__${variantName}`;
 
-export const buildGutterCampaignCode = (testName: string, variantName: string): string =>
-    `gutter__${testName}__${variantName}`;
+export const buildGutterCampaignCode = (testName: GutterTest, variantName: GutterVariant): string =>
+    `gutter__${testName.name}__${variantName.name}`;
 
 export const addQueryParams = (baseUrl: string, queryParams: string) => {
     const alreadyHasQueryString = baseUrl.includes('?');