Bump guardian/libs and eslint - include new config and fixes (#1316)

* bump guardian/libs to 22.0.1 plus associated peer dependencies and eslint config file change

* add rules and ignores

* first run of new eslint config fix

* Turn off all rules for now with a view to fixing later or retaining

* second pass of --fix

* Add link to trello card for fixing later

* Remove old eslint config files

* Fix eslint script + config

* auto lint fixes

* unnecessary export

* exclude rules

* exclude cdk

* fix cdk lint script

* Move to use ACQUISITIONS_GUTTER

* Revert - to be done in a separate PR

---------

Co-authored-by: Sue Burt <“sue.burt@guardian.co.uk”>
Co-authored-by: Tom Forbes <tom.forbes@theguardian.com>

Author: 3 people

.eslintignore

@@ -7,7 +7,7 @@
     "test": "jest",
     "test-update": "jest -u",
     "format": "prettier --write \"{lib,bin}/**/*.ts\"",
-    "lint": "eslint lib/** bin/** --ext .ts --no-error-on-unmatched-pattern",
+    "lint": "eslint lib/** bin/** --no-error-on-unmatched-pattern",
     "synth": "cdk synth --path-metadata false --version-reporting false",
     "diff": "cdk diff --path-metadata false --version-reporting false"
   },

.eslintrc.js

@@ -0,0 +1,69 @@
+import guardian from '@guardian/eslint-config';
+import globals from 'globals';
+
+export default [
+	{
+		ignores: [
+			'node_modules',
+			'dist',
+            'server-dist',
+
+			'rollup.config.js',
+			'webpack.*js',
+            'cdk',
+		],
+	},
+	...guardian.configs.recommended,
+	...guardian.configs.jest,
+	{
+        ignores: ['eslint.config.mjs'],
+        languageOptions: {
+            globals: {
+                ...globals.jest,
+                ...globals.browser,
+                ...globals.node,
+            },
+            ecmaVersion: 5,
+            sourceType: 'commonjs',
+            parserOptions: {
+                project: ['./tsconfig.json'],
+                tsconfigRootDir: './',
+            },
+        },
+		rules: {
+			// Place to specify ESLint rules. Can be used to overwrite rules specified from the extended configs
+			// e.g. "@typescript-eslint/explicit-function-return-type": "off",
+			curly: 2,
+			// '@typescript-eslint/no-unused-vars': [
+			// 	'error',
+			// 	{
+			// 		args: 'after-used',
+			// 		ignoreRestSiblings: true,
+			// 	},
+			// ],
+
+			// potentially to fix later see https://trello.com/c/lc8lG7Zj
+			'@typescript-eslint/naming-convention': 'off',
+			'@eslint-community/eslint-comments/require-description': 'off',
+			'@typescript-eslint/ban-types': 'off',
+			'@typescript-eslint/no-unsafe-function-type': 'off',
+			'@typescript-eslint/no-unnecessary-condition': 'off',
+			'@typescript-eslint/no-unsafe-assignment': 'off',
+			'@typescript-eslint/prefer-nullish-coalescing': 'off',
+			'@typescript-eslint/no-unsafe-member-access': 'off',
+			'@typescript-eslint/require-await': 'off',
+			'@typescript-eslint/no-unsafe-enum-comparison': 'off',
+			'@typescript-eslint/no-unsafe-argument': 'off',
+			'@typescript-eslint/no-unsafe-return': 'off',
+			'@typescript-eslint/no-base-to-string': 'off',
+			'@typescript-eslint/prefer-promise-reject-errors': 'off',
+			'@typescript-eslint/no-unsafe-call': 'off',
+			'@typescript-eslint/no-floating-promise': 'off',
+			'@typescript-eslint/no-unused-vars': 'off',
+			'@typescript-eslint/restrict-template-expressions': 'off',
+			'@typescript-eslint/no-floating-promises': 'off',
+            '@typescript-eslint/prefer-optional-chain': 'off',
+            '@typescript-eslint/await-thenable': 'off',
+		},
+	},
+];

cdk/package.json

@@ -21,15 +21,15 @@
         "build-dotcom-types": "tsc --project tsconfig.types.json",
         "publish-dry-run": "pnpm publish --dry-run",
         "publish": "pnpm publish",
-        "lint": "eslint 'src/**/*.{ts,tsx}'",
+        "lint": "eslint .",
         "test": "export stage=DEV; jest",
         "riffraff": "node-riffraff-artifact"
     },
     "devDependencies": {
         "@babel/core": "^7.23.2",
         "@babel/preset-typescript": "^7.23.2",
         "@changesets/cli": "^2.26.2",
-        "@guardian/eslint-config-typescript": "^7.0.0",
+        "@guardian/eslint-config": "^11.0.0",
         "@guardian/node-riffraff-artifact": "^0.3.2",
         "@guardian/prettier": "^5.0.0",
         "@rollup/plugin-alias": "^3.1.1",
@@ -48,32 +48,33 @@
         "babel-loader": "^9.1.3",
         "body-parser": "^1.20.3",
         "concurrently": "^6.2.0",
-        "eslint": "^8.47.0",
+        "eslint": "^9.19.0",
         "eslint-plugin-prettier": "5.1.3",
         "eslint-plugin-react": "^7.33.2",
         "fishery": "^0.3.0",
+        "globals": "15.14.0",
         "inquirer": "^7.0.3",
         "jest": "^29.7.0",
         "nodemon": "^3.1.7",
         "prettier": "^3.0.0",
         "rollup": "^2.79.2",
-        "rollup-plugin-external-globals": "^0.5.0",
+        "rollup-plugin-external-globals": "^0.13.0",
         "rollup-plugin-filesize": "^9.0.2",
         "rollup-plugin-peer-deps-external": "^2.2.3",
         "rollup-plugin-terser": "^7.0.2",
         "ts-jest": "^29.1.1",
         "ts-loader": "^9.2.5",
         "ts-node-dev": "^2.0.0",
         "tslib": "^2.5.3",
-        "typescript": "~5.1.3",
+        "typescript": "~5.5.2",
         "typescript-json-schema": "^0.42.0",
         "webpack": "^5.94.0",
         "webpack-cli": "^4.7.2",
         "webpack-merge": "^5.8.0",
         "zod": "3.22.4"
     },
     "dependencies": {
-        "@guardian/libs": "17.0.0",
+        "@guardian/libs": "22.0.1",
         "aws-sdk": "^2.862.0",
         "compression": "1.7.4",
         "cors": "^2.8.5",
@@ -86,7 +87,7 @@
         "zod": "3.22.4"
     },
     "peerDependencies": {
-        "@guardian/libs": "^17.0.0",
+        "@guardian/libs": "^22.0.0",
         "zod": "^3.22.4"
     },
     "packageManager": "pnpm@8.15.7"