Fix lint no unnecessary conditions in requests.ts (#1388)

* add prune-suppression script

* remove unnecessary condition

---------

Co-authored-by: sookburt <“sue.burt@guardian.co.uk”>

Author: sookburt

eslint-suppressions.json

@@ -1,9 +1,4 @@
 {
-  "src/dotcom/requests.ts": {
-    "@typescript-eslint/no-unnecessary-condition": {
-      "count": 1
-    }
-  },
   "src/server/api/ampEpicRouter.ts": {
     "@typescript-eslint/no-unsafe-assignment": {
       "count": 3

package.json

@@ -22,6 +22,7 @@
         "publish-dry-run": "pnpm publish --dry-run",
         "publish": "pnpm publish",
         "lint": "eslint .",
+        "prune-lint-suppressions": "pnpm lint --prune-suppressions",
         "prettier:check": "prettier --check ./src",
         "prettier:fix": "prettier --write ./src",
         "test": "export stage=DEV; jest",

src/dotcom/requests.ts

@@ -1,3 +1,4 @@
+import { URLSearchParams } from 'url';
 import type {
     BannerPayload,
     BannerProps,
@@ -25,15 +26,8 @@ export interface ModuleDataResponse<PROPS> {
 type ModuleType = 'epic' | 'liveblog-epic' | 'banner' | 'header' | 'gutter-liveblog';
 
 const getForcedVariant = (type: ModuleType): string | null => {
-    if (URLSearchParams) {
-        const params = new URLSearchParams(window.location.search);
-        const value = params.get(`force-${type}`);
-        if (value) {
-            return value;
-        }
-    }
-
-    return null;
+    const params = new URLSearchParams(window.location.search);
+    return params.get(`force-${type}`);
 };
 
 type Payload = EpicPayload | BannerPayload | HeaderPayload | GutterPayload;