Skip to content

Commit d2d7f54

Browse files
AMP epic logic removed (#1435)
* amp epic logic removed * reminders.ts removed as it's no longer needed. * ts types fix after removal of reminders
1 parent 336f728 commit d2d7f54

File tree

15 files changed

+1
-781
lines changed

15 files changed

+1
-781
lines changed

eslint-suppressions.json

Lines changed: 0 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,4 @@
11
{
2-
"src/server/api/ampEpicRouter.ts": {
3-
"@typescript-eslint/no-unsafe-assignment": {
4-
"count": 3
5-
},
6-
"@typescript-eslint/prefer-nullish-coalescing": {
7-
"count": 2
8-
},
9-
"@typescript-eslint/no-base-to-string": {
10-
"count": 4
11-
},
12-
"@typescript-eslint/restrict-template-expressions": {
13-
"count": 4
14-
},
15-
"@typescript-eslint/no-floating-promises": {
16-
"count": 1
17-
}
18-
},
192
"src/server/api/bannerRouter.ts": {
203
"@typescript-eslint/no-unnecessary-condition": {
214
"count": 1
@@ -77,11 +60,6 @@
7760
"count": 1
7861
}
7962
},
80-
"src/server/lib/ampVariantAssignments.ts": {
81-
"@typescript-eslint/no-base-to-string": {
82-
"count": 1
83-
}
84-
},
8563
"src/server/lib/fetchTickerData.ts": {
8664
"@typescript-eslint/prefer-promise-reject-errors": {
8765
"count": 3
@@ -144,29 +122,6 @@
144122
"count": 1
145123
}
146124
},
147-
"src/server/server.ts": {
148-
"@typescript-eslint/prefer-nullish-coalescing": {
149-
"count": 1
150-
}
151-
},
152-
"src/server/tests/amp/ampEpic.ts": {
153-
"@typescript-eslint/require-await": {
154-
"count": 1
155-
},
156-
"@typescript-eslint/prefer-nullish-coalescing": {
157-
"count": 1
158-
}
159-
},
160-
"src/server/tests/amp/ampEpicSelection.test.ts": {
161-
"@typescript-eslint/no-unsafe-assignment": {
162-
"count": 1
163-
}
164-
},
165-
"src/server/tests/amp/ampEpicSelection.ts": {
166-
"@typescript-eslint/require-await": {
167-
"count": 2
168-
}
169-
},
170125
"src/server/tests/banners/bannerDeployTimes.ts": {
171126
"@typescript-eslint/no-unsafe-argument": {
172127
"count": 5

src/dotcom/types.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,5 @@ export {
77
} from '../shared/types/targeting';
88
export * from '../shared/types/prices';
99
export { EpicProps } from '../shared/types/props/epic';
10-
export * from '../shared/types/reminders';
1110
export { ModuleDataResponse, ModuleData } from './requests';
1211
export { Image } from '../shared/types/props/shared';

src/server/api/ampEpicRouter.ts

Lines changed: 0 additions & 259 deletions
This file was deleted.

src/server/lib/ampVariantAssignments.ts

Lines changed: 0 additions & 20 deletions
This file was deleted.

src/server/lib/tracking.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@ export const buildEpicCampaignCode = (test: EpicTest, variant: EpicVariant): str
1515
export const buildBannerCampaignCode = (test: BannerTest, variant: BannerVariant): string =>
1616
`${test.name}_${variant.name}`;
1717

18-
export const buildAmpEpicCampaignCode = (testName: string, variantName: string): string =>
19-
`AMP__${testName}__${variantName}`;
20-
2118
export const buildGutterCampaignCode = (testName: GutterTest, variantName: GutterVariant): string =>
2219
`gutter__${testName.name}__${variantName.name}`;
2320

0 commit comments

Comments
 (0)