Extend benefits cookie expiry to 30 days

The cookie which tracks when to refresh benefits cookies is reduced to 1
day, like everywhere else.

This is part of a wider change to benefits cookie expiration to fix an
issue where signed-in users with ad free benefits who didn't visit the
site for time period would sometimes see ads on their first returning
pageview. This change makes this less likely to happen by extending the
expiration of user benefits cookies.

This is due to a race condition between the user benefits refresh and
the ads code. However, we don't want to delay ads until after the user
benefits have been refreshed as that would impact performance. So
instead, extend the expiry of the cookie.

See also:
guardian/frontend#28352
guardian/dotcom-rendering#14810
guardian/gateway#3285

Author: tjmw

support-frontend/app/controllers/SubscriptionProductCookiesCreator.scala

@@ -8,9 +8,10 @@ import com.gu.support.workers._
 
 case class SubscriptionProductCookiesCreator(domain: GuardianDomain) {
   private val oneDayInSeconds = 60 * 60 * 24;
-  private val maxAgeInDays = 7
+  private val benefitsCookieLengthInDays = 30
+  private val benefitsExpiryCookieLengthInDays = 1
 
-  private def persistentCookieWithMaxAge(name: String, now: DateTime) = {
+  private def persistentCookieWithMaxAge(name: String, now: DateTime, maxAgeInDays: Int) = {
     val expiryTime = now.plusDays(maxAgeInDays).withTimeAtStartOfDay().getMillis.toString
     Cookie(
       name = name,
@@ -22,16 +23,20 @@ case class SubscriptionProductCookiesCreator(domain: GuardianDomain) {
     )
   }
   private def adFreeCookie(now: DateTime) =
-    persistentCookieWithMaxAge("GU_AF1", now)
+    persistentCookieWithMaxAge(name = "GU_AF1", now = now, maxAgeInDays = benefitsCookieLengthInDays)
 
   private def hideSupportMessagingCookie(now: DateTime) =
-    persistentCookieWithMaxAge("gu_hide_support_messaging", now)
+    persistentCookieWithMaxAge(name = "gu_hide_support_messaging", now = now, maxAgeInDays = benefitsCookieLengthInDays)
 
   private def allowRejectAllCookie(now: DateTime) =
-    persistentCookieWithMaxAge("gu_allow_reject_all", now)
+    persistentCookieWithMaxAge(name = "gu_allow_reject_all", now = now, maxAgeInDays = benefitsCookieLengthInDays)
 
   private def userBenefitsExpiryCookie(now: DateTime) =
-    persistentCookieWithMaxAge("gu_user_benefits_expiry", now)
+    persistentCookieWithMaxAge(
+      name = "gu_user_benefits_expiry",
+      now = now,
+      maxAgeInDays = benefitsExpiryCookieLengthInDays,
+    )
 
   def createCookiesForProduct(product: ProductType, now: DateTime): List[Cookie] = {
     // Setting the user benefits cookies used by frontend. See:

support-frontend/test/controllers/SubscriptionProductCookiesCreatorTest.scala

@@ -13,12 +13,12 @@ class SubscriptionProductCookiesCreatorTest extends AnyFlatSpec with Matchers {
   private val creator = SubscriptionProductCookiesCreator(GuardianDomain("thegulocal.com"))
 
   private def expectedCookie(name: String, ageInDays: Int) = {
-    val ageInSeconds = ageInDays * 24 * 60 * 60
+    val ageInSeconds = BigInt(ageInDays * 24 * 60 * 60)
 
     Cookie(
       name = name,
-      value = s"${now.getMillis + (ageInSeconds * 1000)}",
-      maxAge = Some(ageInSeconds),
+      value = (now.getMillis + (ageInSeconds * 1000)).toString,
+      maxAge = Some(ageInSeconds.toInt),
       secure = true,
       httpOnly = false,
       domain = Some("thegulocal.com"),
@@ -29,9 +29,9 @@ class SubscriptionProductCookiesCreatorTest extends AnyFlatSpec with Matchers {
     val guardianAdLite = GuardianAdLite(GBP)
     val cookies = creator.createCookiesForProduct(guardianAdLite, now)
 
-    cookies should contain(expectedCookie(name = "gu_allow_reject_all", ageInDays = 7))
+    cookies should contain(expectedCookie(name = "gu_allow_reject_all", ageInDays = 30))
     // It should also contain the user features expiry cookie
-    cookies should contain(expectedCookie(name = "gu_user_benefits_expiry", ageInDays = 7))
+    cookies should contain(expectedCookie(name = "gu_user_benefits_expiry", ageInDays = 1))
   }
 
   it should "not set the hide support messaging cookie for Guardian Ad Lite because it is not a supporter product" in {
@@ -40,18 +40,18 @@ class SubscriptionProductCookiesCreatorTest extends AnyFlatSpec with Matchers {
 
     cookies.map(_.name) should not contain "gu_hide_support_messaging"
     // It should also contain the user features expiry cookie
-    cookies should contain(expectedCookie(name = "gu_user_benefits_expiry", ageInDays = 7))
+    cookies should contain(expectedCookie(name = "gu_user_benefits_expiry", ageInDays = 1))
   }
 
   it should "set the ad-free cookie, the hide supporter revenue cookie and the allow reject all cookie for SupporterPlus" in {
     val supporterPlus = SupporterPlus(BigDecimal(12), GBP, Monthly)
     val cookies = creator.createCookiesForProduct(supporterPlus, now)
 
-    cookies should contain(expectedCookie(name = "GU_AF1", ageInDays = 7))
-    cookies should contain(expectedCookie(name = "gu_hide_support_messaging", ageInDays = 7))
-    cookies should contain(expectedCookie(name = "gu_allow_reject_all", ageInDays = 7))
+    cookies should contain(expectedCookie(name = "GU_AF1", ageInDays = 30))
+    cookies should contain(expectedCookie(name = "gu_hide_support_messaging", ageInDays = 30))
+    cookies should contain(expectedCookie(name = "gu_allow_reject_all", ageInDays = 30))
     // It should also contain the user features expiry cookie
-    cookies should contain(expectedCookie(name = "gu_user_benefits_expiry", ageInDays = 7))
+    cookies should contain(expectedCookie(name = "gu_user_benefits_expiry", ageInDays = 1))
   }
 
 }