[BUG] Hidden Services not enable-able through UI (missing prefs toggle?)

[srdjanrosic]

Describe the Bug

Adding and toggling individual hidden services is insufficient to emit HiddenServiceDir and HiddenServicePort lines when generating torrc

In current stable 17.8.0-RC-3-tor-0.4.8.21:

        if (Prefs.hostOnionServicesEnabled) {
            val extraLines = StringBuffer()
            OnionServiceColumns.addV3OnionServicesToTorrc(extraLines, context,
                OnionServiceColumns.createV3OnionDir(context))
            conf.addAll(extraLines.split("\n"))
        }

The addV3OnionServicesToTorrc is never invoked because there's no way through the UI to set hostOnionServicesEnabled to true.

I think it's likely that there was a toggle in some menu somewhere that might have been dropped accidentally during previous refactoring.

To Reproduce
Steps to reproduce the behavior:

1. Go to '... More' > 'Hosted Onion Services' > fill out something / anything (e.g. service name foo, port 12345)
2. See a toast saying you need to restart orbot .. which is fine, because orbot should generate torrc, that will cause the directory to be populated on startup after connecting.
3. ... except that piece of config is never generated, .. and you can't copy the domain name it keeps saying to restart orbot/tor, regardless of what is in those settings.
4. See code above.

Expected Behavior
If there are services defined and toggled on, each should yield a couple of HidderService... lines

What Custom Configuration Do You Use?
Basic fresh install.

Screenshots
I could but, it shouldn't really matter.

Additional Context
none.

[bitmold]

I just fixed this on another branch, it was an issue from some code being rewritten last December for SmartConnect and TorConfig.kt.

I can generate v3 onion services like before on Obrot, however, I can't reach them on another device over the tor network. If I look at the tor logs from Orbot's tor instance, I see that there is a non-fatal assertion in tor's hs_service.c:

/** Set the revision counter in <b>hs_desc</b>. We do this by encrypting a
 *  timestamp using an OPE scheme and using the ciphertext as our revision
 *  counter.
 *
 *  If <b>is_current</b> is true, then this is the current HS descriptor,
 *  otherwise it's the next one. */
static void
set_descriptor_revision_counter(hs_service_descriptor_t *hs_desc, time_t now,
                                bool is_current)
{
// ....



  /* Now we compute the final revision counter value by encrypting the
     plaintext using our OPE cipher: */
  tor_assert(hs_desc->ope_cipher);
  rev_counter = crypto_ope_encrypt(hs_desc->ope_cipher,
                                   (int) seconds_since_start_of_srv);

  /* The OPE module returns CRYPTO_OPE_ERROR in case of errors. */
  tor_assert_nonfatal(rev_counter < CRYPTO_OPE_ERROR);

  log_info(LD_REND, "Encrypted revision counter %d to %" PRIu64,
           (int) seconds_since_start_of_srv, rev_counter);

  hs_desc->desc->plaintext_data.revision_counter = rev_counter;
}

The non-fatal assertion at the end of the method is thrown with tor 0.4.9.5 and tor 0.4.8.22. I can look into this a bit more later in the week.

[phantomtech573]

`"Skip to content
guardianproject
orbot-android
Repository navigation
Code
Issues
111
 (111)
Pull requests
2
 (2)
Discussions
Actions
Projects
Wiki
Security
Insights
[BUG] Hidden Services not enable-able through UI (missing prefs toggle?) #1604
Open

Description
srdjanrosic
opened 3 weeks ago
Describe the Bug

Adding and toggling individual hidden services is insufficient to emit HiddenServiceDir and HiddenServicePort lines when generating torrc

In current stable 17.8.0-RC-3-tor-0.4.8.21:

    if (Prefs.hostOnionServicesEnabled) {
        val extraLines = StringBuffer()
        OnionServiceColumns.addV3OnionServicesToTorrc(extraLines, context,
            OnionServiceColumns.createV3OnionDir(context))
        conf.addAll(extraLines.split("\n"))
    }

The addV3OnionServicesToTorrc is never invoked because there's no way through the UI to set hostOnionServicesEnabled to true.

I think it's likely that there was a toggle in some menu somewhere that might have been dropped accidentally during previous refactoring.

To Reproduce
Steps to reproduce the behavior:

Go to '... More' > 'Hosted Onion Services' > fill out something / anything (e.g. service name foo, port 12345)
See a toast saying you need to restart orbot .. which is fine, because orbot should generate torrc, that will cause the directory to be populated on startup after connecting.
... except that piece of config is never generated, .. and you can't copy the domain name it keeps saying to restart orbot/tor, regardless of what is in those settings.
See code above.
Expected Behavior
If there are services defined and toggled on, each should yield a couple of HidderService... lines

What Custom Configuration Do You Use?
Basic fresh install.

Screenshots
I could but, it shouldn't really matter.

Additional Context
none.

Activity

srdjanrosic
added
bug
3 weeks ago

bitmold
added a commit that references this issue 2 weeks ago
Address Orbot logic issue that caused #1604, however now there is an …

53e90ee

bitmold commented 2 weeks ago
bitmold
2 weeks ago
Collaborator
I just fixed this on another branch, it was an issue from some code being rewritten last December for SmartConnect and TorConfig.kt.

I can generate v3 onion services like before on Obrot, however, I can't reach them on another device over the tor network. If I look at the tor logs from Orbot's tor instance, I see that there is a non-fatal assertion in tor's hs_service.c:

/** Set the revision counter in hs_desc. We do this by encrypting a

• timestamp using an OPE scheme and using the ciphertext as our revision
• counter.
• If is_current is true, then this is the current HS descriptor,
• otherwise it's the next one. */
  static void
  set_descriptor_revision_counter(hs_service_descriptor_t *hs_desc, time_t now,
  bool is_current)
  {
  // ....

/* Now we compute the final revision counter value by encrypting the
plaintext using our OPE cipher: */
tor_assert(hs_desc->ope_cipher);
rev_counter = crypto_ope_encrypt(hs_desc->ope_cipher,
(int) seconds_since_start_of_srv);

/* The OPE module returns CRYPTO_OPE_ERROR in case of errors. */
tor_assert_nonfatal(rev_counter < CRYPTO_OPE_ERROR);

log_info(LD_REND, "Encrypted revision counter %d to %" PRIu64,
(int) seconds_since_start_of_srv, rev_counter);

hs_desc->desc->plaintext_data.revision_counter = rev_counter;
}
The non-fatal assertion at the end of the method is thrown with tor 0.4.9.5 and tor 0.4.8.22. I can look into this a bit more later in the week.

bitmold
added a commit that references this issue 2 weeks ago
Address Orbot logic issue that caused #1604, however now there is an …

a158b93

bitmold
self-assigned this2 weeks ago

bitmold
added a commit that references this issue 2 weeks ago
Dont display toast with done after copying onion service url, modern …

8902e53

Add a comment
new Comment
Markdown input: edit mode selected.
Write
Preview

Remember, contributions to this repository should follow its security policy and Support.
Metadata
Assignees
Labels
bug
Type
No type
Projects
No projects
Milestone
No milestone
Relationships
None yet
Development
No branches or pull requests
NotificationsCustomize
You're not receiving notifications from this thread.

Participants

Issue actions
Footer
© 2026 GitHub, Inc.
Footer navigation
Terms
Privacy
Security
Status
Community
Docs
Contact
Manage cookies
Do not share my personal information
"
https://github.com/guardianproject/orbot-android/issues/1604#:~:text=Skip%20to%20content,my%20personal%20information`