some more minor fixes

Author: sajal-n

src/options/opaImport.js

@@ -17,6 +17,8 @@ export function showOpaImportModal(onSaveCallback) {
       </div>
     `;
     document.body.appendChild(modal);
+    // Ensure newly created modal is visible on first open
+    modal.style.display = 'flex';
   } else {
     modal.style.display = 'flex';
   }

src/options/options.js

@@ -49,16 +49,23 @@ function renderTable() {
     const tdKind = document.createElement("td"); tdKind.textContent = r.kind || "";
     const tdSeverity = document.createElement("td"); tdSeverity.textContent = r.severity || "";
     const tdActions = document.createElement("td");
-    // Restore delete button
+    // Edit button
+    const editBtn = document.createElement("button");
+    editBtn.textContent = "✏️";
+    editBtn.title = "Edit";
+    editBtn.style.padding = "4px 8px";
+    editBtn.onclick = function() {
+      if (typeof window.editRule === "function") { window.editRule(idx); }
+    };
+    tdActions.appendChild(editBtn);
+
+    // Delete button (with confirmation modal)
     const delBtn = document.createElement("button");
     delBtn.textContent = "🗑";
     delBtn.title = "Delete";
     delBtn.style.padding = "4px 8px";
     delBtn.onclick = function() {
-      rules.splice(idx, 1);
-      saveRules();
-      renderTable();
-      showToast("Rule deleted", { background: "#b91c1c" });
+      if (typeof window.deleteRule === "function") { window.deleteRule(idx); }
     };
     tdActions.appendChild(delBtn);
     tr.appendChild(tdId);
@@ -732,7 +739,7 @@ window.editRule = function (idx) {
 };
 
 window.deleteRule = function (idx) {
-  showDeleteConfirmation(idx);
+  showDeleteConfirmation(idx, rules, saveRules, renderTable, showToast);
 };
 
 

src/popup/popup.js

@@ -353,9 +353,10 @@ async function initPopup() {
                 }
               }
             }
+            const hasSchemas = !!(csData && ((Array.isArray(csData.openapis) && csData.openapis.length > 0) || (Array.isArray(csData.crds) && csData.crds.length > 0) || csData.openapi));
             if (schemaResults.length === 0) {
-              if (csData && csData.openapis && Object.keys(csData.openapis).length > 0) {
-                schemaDiagnostic = "Schema present, but no matching schema found for this resource. Check apiVersion/kind and schema keys.";
+              if (hasSchemas) {
+                schemaDiagnostic = "Schema-based validation: no issues found for this resource.";
               } else {
                 schemaDiagnostic = "No schema present for this resource.";
               }
@@ -540,9 +541,10 @@ async function initPopup() {
           }
         }
         // Diagnostic: show what schema was matched and summary of results
+        const hasSchemas = !!(csData && ((Array.isArray(csData.openapis) && csData.openapis.length > 0) || (Array.isArray(csData.crds) && csData.crds.length > 0) || csData.openapi));
         if (schemaResults.length === 0) {
-          if (csData && csData.openapis && Object.keys(csData.openapis).length > 0) {
-            schemaDiagnostic = "Schema present, but no matching schema found for this resource. Check apiVersion/kind and schema keys.";
+          if (hasSchemas) {
+            schemaDiagnostic = "Schema-based validation: no issues found for this resource.";
           } else {
             schemaDiagnostic = "No schema present for this resource.";
           }