Skip to content

Commit 48c93f4

Browse files
committed
address PR comments
1 parent cbcd550 commit 48c93f4

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

guardrails/utils/casting_utils.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from typing import Any, Optional
2+
import warnings
23

34

45
def to_int(v: Any) -> Optional[int]:
@@ -30,4 +31,5 @@ def to_bool(value: str) -> Optional[bool]:
3031
return True
3132
if value.lower() == "false":
3233
return False
34+
warnings.warn(f"Could not cast {value} to bool. Returning None.")
3335
return None

tests/integration_tests/test_telemetry.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,6 @@ def test_private_traces_go_to_user_telem_sink(self, mocker):
5252
private_spans = private_exporter.get_finished_spans()
5353
hub_spans = hub_exporter.get_finished_spans()
5454

55-
print("Private spans: ", private_spans)
56-
print(" ")
57-
print("Hub spans: ", hub_spans)
58-
5955
assert len(private_spans) == 4
6056
assert len(hub_spans) == 0
6157

0 commit comments

Comments
 (0)