add 'other' to invalid topics in every case

Author: zsimjee

guardrails/validators/on_topic.py

@@ -220,7 +220,9 @@ def get_topic_zero_shot(
         score = result["scores"][0]  # type: ignore
         return topic, score  # type: ignore
 
-    def validate(self, value: str, metadata: Dict[str, Any]) -> ValidationResult:
+    def validate(
+        self, value: str, metadata: Optional[Dict[str, Any]]
+    ) -> ValidationResult:
         valid_topics = set(self._valid_topics)
         invalid_topics = set(self._invalid_topics)
 
@@ -236,7 +238,7 @@ def validate(self, value: str, metadata: Dict[str, Any]) -> ValidationResult:
 
         # Add 'other' to the invalid topics list
         if "other" not in invalid_topics:
-            self._invalid_topics.append("other")
+            invalid_topics.add("other")
 
         # Combine valid and invalid topics
         candidate_topics = valid_topics.union(invalid_topics)

tests/integration_tests/validators/test_on_topic.py

@@ -24,7 +24,6 @@ def test_validate_invalid_topic_cpu_disable_llm(self):
             valid_topics=["sports", "politics"],
             disable_classifier=False,
             disable_llm=True,
-            model_threshold=0.6,
         )
         text = "This is an article about music."
         expected_result = FailResult(error_message="Most relevant topic is other.")