Removed writes to org namespaced init files during install, removed unused methods

Author: AlejandroEsquivel

guardrails/hub/validator_package_service.py

@@ -7,7 +7,6 @@
 
 from typing import List, Literal, Optional
 from types import ModuleType
-from pydash.strings import snake_case
 from packaging.utils import canonicalize_name  # PEP 503
 
 from guardrails.logger import logger as guardrails_logger
@@ -104,20 +103,9 @@ def get_validator_from_manifest(manifest: Manifest) -> ModuleType:
         # Reload or import the module
         return ValidatorPackageService.reload_module(import_line)
 
-    @staticmethod
-    def get_org_and_package_dirs(
-        manifest: Manifest,
-    ) -> List[str]:
-        org_name = manifest.namespace
-        package_name = manifest.package_name
-        org = snake_case(org_name if len(org_name) > 1 else "")
-        package = snake_case(package_name if len(package_name) > 1 else package_name)
-        return list(filter(None, [org, package]))
-
     @staticmethod
     def add_to_hub_inits(manifest: Manifest, site_packages: str):
         validator_id = manifest.id
-        org_package = ValidatorPackageService.get_org_and_package_dirs(manifest)
         exports: List[str] = manifest.exports or []
         sorted_exports = sorted(exports, reverse=True)
 
@@ -141,27 +129,6 @@ def add_to_hub_inits(manifest: Manifest, site_packages: str):
                 hub_init.write(import_line)
                 hub_init.close()
 
-        namespace = org_package[0]
-        namespace_init_location = os.path.join(
-            site_packages, "guardrails", "hub", namespace, "__init__.py"
-        )
-        if os.path.isfile(namespace_init_location):
-            with open(namespace_init_location, "a+") as namespace_init:
-                namespace_init.seek(0, 0)
-                content = namespace_init.read()
-                if import_line in content:
-                    namespace_init.close()
-                else:
-                    namespace_init.seek(0, 2)
-                    if len(content) > 0:
-                        namespace_init.write("\n")
-                    namespace_init.write(import_line)
-                    namespace_init.close()
-        else:
-            with open(namespace_init_location, "w") as namespace_init:
-                namespace_init.write(import_line)
-                namespace_init.close()
-
     @staticmethod
     def get_module_path(package_name):
         try:

tests/unit_tests/hub/test_validator_package_service.py

@@ -487,53 +487,6 @@ def test_get_validator_from_manifest(self, mock_reload_module):
 
         mock_reload_module.assert_called_once_with("guardrails_grhub_id")
 
-    @pytest.mark.parametrize(
-        "manifest,expected",
-        [
-            (
-                Manifest.from_dict(
-                    {
-                        "id": "guardrails-ai/id",
-                        "name": "name",
-                        "author": {"name": "me", "email": "[email protected]"},
-                        "maintainers": [],
-                        "repository": {"url": "some-repo"},
-                        "namespace": "guardrails-ai",
-                        "packageName": "test-validator",
-                        "moduleName": "test_validator",
-                        "description": "description",
-                        "exports": ["TestValidator"],
-                        "tags": {},
-                    }
-                ),
-                ["guardrails_ai", "test_validator"],
-            ),
-            (
-                Manifest.from_dict(
-                    {
-                        "id": "guardrails-ai/id",
-                        "name": "name",
-                        "author": {"name": "me", "email": "[email protected]"},
-                        "maintainers": [],
-                        "repository": {"url": "some-repo"},
-                        "namespace": "",
-                        "packageName": "test-validator",
-                        "moduleName": "test_validator",
-                        "description": "description",
-                        "exports": ["TestValidator"],
-                        "tags": {},
-                    }
-                ),
-                ["test_validator"],
-            ),
-        ],
-    )
-    def test_get_org_and_package_dirs(self, manifest, expected):
-        from guardrails.hub.validator_package_service import ValidatorPackageService
-
-        actual = ValidatorPackageService.get_org_and_package_dirs(manifest)
-        assert actual == expected
-
     def test_get_module_name_valid(self):
         module_name, module_version = ValidatorPackageService.get_validator_id(
             "hub://test-module>=1.0.0"