Skip to content

Enhance Publish to GR PyPi Action to allow package folder input #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

Enhance Publish to GR PyPi Action to allow package folder input #1208

merged 1 commit into from
Jan 7, 2025

Conversation

@AlejandroEsquivel
Copy link
Member

@AlejandroEsquivel AlejandroEsquivel commented Jan 7, 2025

No description provided.

@AlejandroEsquivel AlejandroEsquivel marked this pull request as ready for review January 7, 2025 20:57
@AlejandroEsquivel AlejandroEsquivel requested a review from a team January 7, 2025 21:01
JosephCatrambone
JosephCatrambone approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@JosephCatrambone JosephCatrambone left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; haven't tested locally.

EDIT: Just thought of something: do we need a default for 'validator'?
EDIT EDIT: Nevermind. You've got it.

@AlejandroEsquivel AlejandroEsquivel merged commit f17e98c into main Jan 7, 2025
12 checks passed
@AlejandroEsquivel AlejandroEsquivel deleted the feat/enhance-publish-gr-pypi-action branch January 7, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JosephCatrambone JosephCatrambone JosephCatrambone approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlejandroEsquivel @JosephCatrambone