Fix CI errors: formatting, unused mut, clippy warnings

Author: guardsarm

Cargo.toml

@@ -14,7 +14,7 @@ tokio = { version = "1.35", features = ["full"] }
 futures = "0.3"
 serde = { version = "1.0", features = ["derive"] }
 serde_json = "1.0"
-chrono = "0.4"
+chrono = { version = "0.4", features = ["serde"] }
 thiserror = "1.0"
 regex = "1.10"
 

examples/scan_network.rs

@@ -84,6 +84,7 @@ async fn main() {
         timeout_ms: 500,       // Faster timeout
         concurrent_scans: 200, // More concurrent scans
         detect_services: true,
+        grab_banners: true,
     };
 
     let fast_scanner = NetworkScanner::with_config(custom_config);
@@ -127,17 +128,15 @@ async fn main() {
     println!("\n5. Exporting Results as JSON");
 
     match scanner.scan_common_ports(ip).await {
-        Ok(result) => {
-            match result.to_json() {
-                Ok(json) => {
-                    println!("   JSON export successful:");
-                    println!("{}", json);
-                }
-                Err(e) => {
-                    eprintln!("   JSON export error: {}", e);
-                }
+        Ok(result) => match result.to_json() {
+            Ok(json) => {
+                println!("   JSON export successful:");
+                println!("{}", json);
             }
-        }
+            Err(e) => {
+                eprintln!("   JSON export error: {}", e);
+            }
+        },
         Err(e) => {
             eprintln!("   Scan error: {}", e);
         }

src/lib.rs

@@ -122,9 +122,7 @@ impl ScanResult {
     pub fn get_high_risk_ports(&self) -> Vec<&PortScanResult> {
         self.open_ports
             .iter()
-            .filter(|p| {
-                matches!(p.risk_level, PortRiskLevel::Critical | PortRiskLevel::High)
-            })
+            .filter(|p| matches!(p.risk_level, PortRiskLevel::Critical | PortRiskLevel::High))
             .collect()
     }
 
@@ -267,7 +265,7 @@ impl NetworkScanner {
         }
 
         // Process remaining tasks
-        let mut all_results = join_all(tasks).await;
+        let all_results = join_all(tasks).await;
 
         let scan_end = Utc::now();
 
@@ -302,8 +300,8 @@ impl NetworkScanner {
     /// Scan common ports (top 20)
     pub async fn scan_common_ports(&self, ip: IpAddr) -> Result<ScanResult, ScanError> {
         let common_ports = vec![
-            20, 21, 22, 23, 25, 53, 80, 110, 143, 443, 445, 993, 995, 3306, 3389, 5432, 5900,
-            8080, 8443, 27017,
+            20, 21, 22, 23, 25, 53, 80, 110, 143, 443, 445, 993, 995, 3306, 3389, 5432, 5900, 8080,
+            8443, 27017,
         ];
 
         let scan_start = Utc::now();
@@ -376,26 +374,20 @@ impl NetworkScanner {
     /// Grab service banner from open port
     async fn grab_banner(stream: &mut TcpStream, port: u16) -> Result<String, ScanError> {
         // Send protocol-specific probes
-        let probe = match port {
+        let probe: &[u8] = match port {
             80 | 8080 => b"HEAD / HTTP/1.0\r\n\r\n",
             21 | 22 | 23 | 25 => b"", // These typically send banner on connect
-            _ => b"", // Default: just read
+            _ => b"",                 // Default: just read
         };
 
         if !probe.is_empty() {
-            let _ = timeout(
-                Duration::from_millis(500),
-                stream.write_all(probe),
-            )
-            .await;
+            let _ = timeout(Duration::from_millis(500), stream.write_all(probe)).await;
         }
 
         let mut buffer = vec![0u8; 1024];
         match timeout(Duration::from_millis(500), stream.read(&mut buffer)).await {
             Ok(Ok(n)) if n > 0 => {
-                let banner = String::from_utf8_lossy(&buffer[..n])
-                    .trim()
-                    .to_string();
+                let banner = String::from_utf8_lossy(&buffer[..n]).trim().to_string();
                 if !banner.is_empty() {
                     Ok(banner)
                 } else {
@@ -545,17 +537,12 @@ mod tests {
 
         assert!(result.port == 9999);
         // Status could be Closed or Filtered depending on system
-        assert!(
-            result.status == PortStatus::Closed || result.status == PortStatus::Filtered
-        );
+        assert!(result.status == PortStatus::Closed || result.status == PortStatus::Filtered);
     }
 
     #[tokio::test]
     async fn test_service_detection() {
-        assert_eq!(
-            NetworkScanner::detect_service(80),
-            Some("HTTP".to_string())
-        );
+        assert_eq!(NetworkScanner::detect_service(80), Some("HTTP".to_string()));
         assert_eq!(
             NetworkScanner::detect_service(443),
             Some("HTTPS".to_string())
@@ -596,7 +583,10 @@ mod tests {
             NetworkScanner::assess_port_risk(23),
             PortRiskLevel::Critical
         ); // Telnet
-        assert_eq!(NetworkScanner::assess_port_risk(21), PortRiskLevel::Critical); // FTP
+        assert_eq!(
+            NetworkScanner::assess_port_risk(21),
+            PortRiskLevel::Critical
+        ); // FTP
 
         // High risk
         assert_eq!(NetworkScanner::assess_port_risk(3389), PortRiskLevel::High); // RDP
@@ -699,7 +689,7 @@ mod tests {
         };
 
         let duration = result.scan_duration_secs();
-        assert!(duration >= 0.1 && duration < 1.0);
+        assert!((0.1..1.0).contains(&duration));
     }
 
     #[tokio::test]

src/service_detection.rs

@@ -67,7 +67,9 @@ impl ServiceSignatures {
     fn extract_ssh_version(banner: &str) -> Option<String> {
         if let Some(start) = banner.find("SSH-") {
             let version_str = &banner[start..];
-            if let Some(end) = version_str.find(|c: char| c.is_whitespace() || c == '\r' || c == '\n') {
+            if let Some(end) =
+                version_str.find(|c: char| c.is_whitespace() || c == '\r' || c == '\n')
+            {
                 return Some(version_str[..end].to_string());
             }
         }
@@ -183,7 +185,11 @@ impl BannerGrabber {
     }
 
     /// Grab banner with HTTP probe
-    pub async fn grab_http_banner(host: &str, port: u16, timeout_ms: u64) -> Result<String, String> {
+    pub async fn grab_http_banner(
+        host: &str,
+        port: u16,
+        timeout_ms: u64,
+    ) -> Result<String, String> {
         let addr = format!("{}:{}", host, port);
         let connect_timeout = Duration::from_millis(timeout_ms);
 
@@ -200,10 +206,13 @@ impl BannerGrabber {
             host
         );
 
-        timeout(Duration::from_millis(timeout_ms), stream.write_all(request.as_bytes()))
-            .await
-            .map_err(|_| "Write timeout".to_string())?
-            .map_err(|e| format!("Write failed: {}", e))?;
+        timeout(
+            Duration::from_millis(timeout_ms),
+            stream.write_all(request.as_bytes()),
+        )
+        .await
+        .map_err(|_| "Write timeout".to_string())?
+        .map_err(|e| format!("Write failed: {}", e))?;
 
         // Read response
         let mut buffer = vec![0u8; 4096];
@@ -239,8 +248,9 @@ mod tests {
 
     #[test]
     fn test_mysql_detection() {
-        let banner = "5.7.32-0ubuntu0.18.04.1";
-        let service = ServiceSignatures::detect_from_banner("mysql 5.7.32-0ubuntu0.18.04.1").unwrap();
+        let _banner = "5.7.32-0ubuntu0.18.04.1";
+        let service =
+            ServiceSignatures::detect_from_banner("mysql 5.7.32-0ubuntu0.18.04.1").unwrap();
         assert_eq!(service.name, "MySQL");
     }