Fix CI: clippy warnings, formatting, and remove missing examples

guardsarm · guardsarm · commit f6ec9738b1b0 · 2025-12-11T01:36:53.000-08:00
diff --git a/Cargo.toml b/Cargo.toml
@@ -34,14 +34,3 @@ tempfile = "3.8"
 name = "validate_transactions"
 path = "examples/validate_transactions.rs"
 
-[[example]]
-name = "batch_validation"
-path = "examples/batch_validation.rs"
-
-[[example]]
-name = "compliance_report"
-path = "examples/compliance_report.rs"
-
-[[bench]]
-name = "validator_benchmark"
-harness = false
diff --git a/src/fraud_patterns.rs b/src/fraud_patterns.rs
@@ -286,10 +286,7 @@ impl FraudDetector {
 
     fn add_to_history(&mut self, transaction: Transaction) {
         if let Some(account) = transaction.from_account.clone() {
-            self.history
-                .entry(account)
-                .or_default()
-                .push(transaction);
+            self.history.entry(account).or_default().push(transaction);
         }
     }
 
diff --git a/src/geographic_risk.rs b/src/geographic_risk.rs
@@ -34,7 +34,10 @@ impl CountryRisk {
 
     /// Check if enhanced due diligence is required
     pub fn requires_edd(&self) -> bool {
-        matches!(self.risk_level, CountryRiskLevel::High | CountryRiskLevel::Prohibited)
+        matches!(
+            self.risk_level,
+            CountryRiskLevel::High | CountryRiskLevel::Prohibited
+        )
     }
 }
 
@@ -46,7 +49,7 @@ pub struct JurisdictionRisk {
     pub is_offshore: bool,
     pub is_fatf_greylist: bool,
     pub is_fatf_blacklist: bool,
-    pub transparency_score: u8, // 0-100
+    pub transparency_score: u8,  // 0-100
     pub regulatory_strength: u8, // 0-100
     pub overall_risk: CountryRiskLevel,
 }
@@ -117,10 +120,7 @@ impl GeographicRiskScorer {
             country_name: "North Korea".to_string(),
             risk_level: CountryRiskLevel::Prohibited,
             risk_score: 100,
-            factors: vec![
-                "FATF Blacklist".to_string(),
-                "UN Sanctions".to_string(),
-            ],
+            factors: vec!["FATF Blacklist".to_string(), "UN Sanctions".to_string()],
             fatf_status: Some("Blacklist".to_string()),
             sanctions_programs: vec!["OFAC North Korea".to_string(), "UN Sanctions".to_string()],
         });
@@ -144,7 +144,10 @@ impl GeographicRiskScorer {
             country_name: "Myanmar".to_string(),
             risk_level: CountryRiskLevel::High,
             risk_score: 80,
-            factors: vec!["FATF Greylist".to_string(), "Targeted Sanctions".to_string()],
+            factors: vec![
+                "FATF Greylist".to_string(),
+                "Targeted Sanctions".to_string(),
+            ],
             fatf_status: Some("Greylist".to_string()),
             sanctions_programs: vec![],
         });
@@ -154,7 +157,10 @@ impl GeographicRiskScorer {
             country_name: "Yemen".to_string(),
             risk_level: CountryRiskLevel::High,
             risk_score: 75,
-            factors: vec!["Conflict Zone".to_string(), "Targeted Sanctions".to_string()],
+            factors: vec![
+                "Conflict Zone".to_string(),
+                "Targeted Sanctions".to_string(),
+            ],
             fatf_status: None,
             sanctions_programs: vec![],
         });
@@ -243,7 +249,8 @@ impl GeographicRiskScorer {
 
     /// Add a jurisdiction risk entry
     pub fn add_jurisdiction_risk(&mut self, risk: JurisdictionRisk) {
-        self.jurisdiction_risks.insert(risk.jurisdiction.clone(), risk);
+        self.jurisdiction_risks
+            .insert(risk.jurisdiction.clone(), risk);
     }
 
     /// Get country risk by ISO code
@@ -257,7 +264,11 @@ impl GeographicRiskScorer {
     }
 
     /// Calculate transaction risk based on origin and destination countries
-    pub fn calculate_transaction_risk(&self, origin: &str, destination: &str) -> TransactionGeographicRisk {
+    pub fn calculate_transaction_risk(
+        &self,
+        origin: &str,
+        destination: &str,
+    ) -> TransactionGeographicRisk {
         let origin_risk = self.get_country_risk(origin);
         let dest_risk = self.get_country_risk(destination);
 
@@ -267,11 +278,11 @@ impl GeographicRiskScorer {
         // Use the higher of the two risks, weighted
         let combined_score = ((origin_score as u16 * 40 + dest_score as u16 * 60) / 100) as u8;
 
-        let is_prohibited = origin_risk.map_or(false, |r| r.is_prohibited())
-            || dest_risk.map_or(false, |r| r.is_prohibited());
+        let is_prohibited = origin_risk.is_some_and(|r| r.is_prohibited())
+            || dest_risk.is_some_and(|r| r.is_prohibited());
 
-        let requires_edd = origin_risk.map_or(false, |r| r.requires_edd())
-            || dest_risk.map_or(false, |r| r.requires_edd());
+        let requires_edd = origin_risk.is_some_and(|r| r.requires_edd())
+            || dest_risk.is_some_and(|r| r.requires_edd());
 
         let risk_level = if is_prohibited {
             CountryRiskLevel::Prohibited
diff --git a/src/lib.rs b/src/lib.rs
@@ -32,15 +32,15 @@
 
 pub mod aml_compliance;
 pub mod fraud_patterns;
-pub mod sanctions;
 pub mod geographic_risk;
 pub mod network_analysis;
+pub mod sanctions;
 
 pub use aml_compliance::{AMLChecker, AMLResult, KYCValidationResult, KYCValidator};
 pub use fraud_patterns::{FraudDetector, FraudScore, FraudThresholds, RiskLevel};
-pub use sanctions::{SanctionsScreener, SanctionsResult, SanctionsList};
-pub use geographic_risk::{GeographicRiskScorer, CountryRisk, JurisdictionRisk};
-pub use network_analysis::{TransactionGraph, NetworkAnalyzer, SuspiciousPattern};
+pub use geographic_risk::{CountryRisk, GeographicRiskScorer, JurisdictionRisk};
+pub use network_analysis::{NetworkAnalyzer, SuspiciousPattern, TransactionGraph};
+pub use sanctions::{SanctionsList, SanctionsResult, SanctionsScreener};
 
 use chrono::{DateTime, Duration, Timelike, Utc};
 use regex::Regex;
@@ -605,11 +605,7 @@ mod tests {
     fn create_valid_transaction() -> Transaction {
         // Create timestamp at 12 PM UTC (business hours) to minimize time-based risk
         let now = Utc::now();
-        let timestamp = now
-            .date_naive()
-            .and_hms_opt(12, 0, 0)
-            .unwrap()
-            .and_utc();
+        let timestamp = now.date_naive().and_hms_opt(12, 0, 0).unwrap().and_utc();
 
         Transaction {
             transaction_id: "TXN-001".to_string(),
@@ -638,7 +634,11 @@ mod tests {
             eprintln!("Risk breakdown: {:?}", result.risk_breakdown);
         }
 
-        assert!(result.is_valid, "Transaction should be valid. Errors: {:?}, Fraud score: {}", result.errors, result.fraud_score);
+        assert!(
+            result.is_valid,
+            "Transaction should be valid. Errors: {:?}, Fraud score: {}",
+            result.errors, result.fraud_score
+        );
         assert!(result.errors.is_empty());
     }
 
diff --git a/src/network_analysis.rs b/src/network_analysis.rs
@@ -2,7 +2,7 @@
 //!
 //! Provides graph-based analysis for detecting suspicious transaction patterns.
 
-use chrono::{DateTime, Duration, Utc};
+use chrono::{DateTime, Utc};
 use serde::{Deserialize, Serialize};
 use std::collections::{HashMap, HashSet};
 
@@ -29,6 +29,7 @@ pub enum SuspiciousPattern {
 
 /// Transaction node in the graph
 #[derive(Debug, Clone)]
+#[allow(dead_code)]
 struct TransactionNode {
     account_id: String,
     total_inflow: f64,
@@ -59,6 +60,7 @@ impl TransactionNode {
         self.incoming_accounts.len() >= 5 && self.outgoing_accounts.len() <= 2
     }
 
+    #[allow(dead_code)]
     fn is_distributor(&self) -> bool {
         // Few incoming, many outgoing
         self.incoming_accounts.len() <= 2 && self.outgoing_accounts.len() >= 5
@@ -76,6 +78,7 @@ impl TransactionNode {
 
 /// Edge in the transaction graph
 #[derive(Debug, Clone)]
+#[allow(dead_code)]
 struct TransactionEdge {
     from_account: String,
     to_account: String,
@@ -136,13 +139,16 @@ impl TransactionGraph {
 
         // Update edge
         let edge_key = (from_account.to_string(), to_account.to_string());
-        let edge = self.edges.entry(edge_key.clone()).or_insert_with(|| TransactionEdge {
-            from_account: from_account.to_string(),
-            to_account: to_account.to_string(),
-            total_amount: 0.0,
-            transaction_count: 0,
-            timestamps: Vec::new(),
-        });
+        let edge = self
+            .edges
+            .entry(edge_key.clone())
+            .or_insert_with(|| TransactionEdge {
+                from_account: from_account.to_string(),
+                to_account: to_account.to_string(),
+                total_amount: 0.0,
+                transaction_count: 0,
+                timestamps: Vec::new(),
+            });
         edge.total_amount += amount;
         edge.transaction_count += 1;
         edge.timestamps.push(timestamp);
@@ -226,7 +232,7 @@ impl TransactionGraph {
         let mut results = Vec::new();
         let threshold_margin = self.reporting_threshold * 0.15; // 15% below threshold
 
-        for (account_id, node) in &self.nodes {
+        for account_id in self.nodes.keys() {
             // Get all outgoing transaction amounts for this account
             let mut suspicious_amounts = Vec::new();
 
@@ -347,13 +353,7 @@ impl NetworkAnalyzer {
     }
 
     /// Add transaction to the analyzer
-    pub fn add_transaction(
-        &mut self,
-        from: &str,
-        to: &str,
-        amount: f64,
-        timestamp: DateTime<Utc>,
-    ) {
+    pub fn add_transaction(&mut self, from: &str, to: &str, amount: f64, timestamp: DateTime<Utc>) {
         self.graph.add_transaction(from, to, amount, timestamp);
     }
 
diff --git a/src/sanctions.rs b/src/sanctions.rs
@@ -56,13 +56,18 @@ impl SanctionsResult {
     /// Get highest confidence match
     pub fn highest_confidence(&self) -> Option<&SanctionsMatch> {
         self.matches.iter().max_by(|a, b| {
-            a.confidence.partial_cmp(&b.confidence).unwrap_or(std::cmp::Ordering::Equal)
+            a.confidence
+                .partial_cmp(&b.confidence)
+                .unwrap_or(std::cmp::Ordering::Equal)
         })
     }
 
     /// Get matches above threshold
     pub fn matches_above_threshold(&self, threshold: f32) -> Vec<&SanctionsMatch> {
-        self.matches.iter().filter(|m| m.confidence >= threshold).collect()
+        self.matches
+            .iter()
+            .filter(|m| m.confidence >= threshold)
+            .collect()
     }
 }
 
@@ -216,8 +221,10 @@ impl SanctionsScreener {
 
             // Partial match (contains)
             if entity.name.contains(&name_upper) || name_upper.contains(&entity.name) {
-                let partial_conf = 0.7 + (0.2 * (name_upper.len().min(entity.name.len()) as f32
-                    / name_upper.len().max(entity.name.len()) as f32));
+                let partial_conf = 0.7
+                    + (0.2
+                        * (name_upper.len().min(entity.name.len()) as f32
+                            / name_upper.len().max(entity.name.len()) as f32));
 
                 if !matches.iter().any(|m| m.entry_id == entity.id) {
                     matches.push(SanctionsMatch {
@@ -234,7 +241,11 @@ impl SanctionsScreener {
         }
 
         // Sort by confidence
-        matches.sort_by(|a, b| b.confidence.partial_cmp(&a.confidence).unwrap_or(std::cmp::Ordering::Equal));
+        matches.sort_by(|a, b| {
+            b.confidence
+                .partial_cmp(&a.confidence)
+                .unwrap_or(std::cmp::Ordering::Equal)
+        });
 
         SanctionsResult {
             screened_value: name.to_string(),
@@ -261,9 +272,7 @@ impl SanctionsScreener {
         let max_len = len1.max(len2);
 
         // Simple character-based similarity
-        let common_chars: usize = s1.chars()
-            .filter(|c| s2.contains(*c))
-            .count();
+        let common_chars: usize = s1.chars().filter(|c| s2.contains(*c)).count();
 
         let char_similarity = common_chars as f32 / max_len as f32;
 
@@ -324,7 +333,10 @@ mod tests {
         let result = screener.screen("ENTITY ONE");
 
         assert!(result.is_match);
-        assert!(result.matches.iter().any(|m| m.match_type == MatchType::Alias));
+        assert!(result
+            .matches
+            .iter()
+            .any(|m| m.match_type == MatchType::Alias));
     }
 
     #[test]
@@ -377,7 +389,7 @@ mod tests {
         screener.set_fuzzy_threshold(0.95); // Very strict
 
         let result = screener.screen("SANCTIONED ENTTY ONE"); // Typo
-        // Should have lower confidence due to typo
+                                                              // Should have lower confidence due to typo
         if result.is_match {
             assert!(result.matches[0].confidence < 1.0);
         }

Original file line number	Diff line number	Diff line change
`@@ -286,10 +286,7 @@ impl FraudDetector {`
`286`	`286`
`287`	`287`	`fn add_to_history(&mut self, transaction: Transaction) {`
`288`	`288`	`if let Some(account) = transaction.from_account.clone() {`
`289`		`- self.history`
`290`		`- .entry(account)`
`291`		`- .or_default()`
`292`		`- .push(transaction);`
	`289`	`+ self.history.entry(account).or_default().push(transaction);`
`293`	`290`	`}`
`294`	`291`	`}`
`295`	`292`