-
Notifications
You must be signed in to change notification settings - Fork 737
Description
Currently the PopupAutocomplete:
Terminal.Gui/Terminal.Gui/Views/Autocomplete/PopupAutocomplete.cs
Lines 421 to 430 in e7a4df4
| protected void Close () | |
| { | |
| ClearSuggestions (); | |
| Visible = false; | |
| _closed = true; | |
| //RemovePopupFromTop (); | |
| _popup.Visible = false; | |
| HostControl?.SetNeedsDraw (); | |
| } |
Always seem to set _popup.Visible = false; on Close.
In the TextField context, if the user is clearing current word this becomes an issue.
The RenderOverlay calls Close:
Terminal.Gui/Terminal.Gui/Views/Autocomplete/PopupAutocomplete.cs
Lines 268 to 275 in e7a4df4
| else if (!Visible || HostControl?.HasFocus == false || Suggestions.Count == 0) | |
| { | |
| LastPopupPos = null; | |
| if (Visible) | |
| { | |
| Close (); | |
| } |
whenever the Suggestions.Count becomes 0, so when the user is clearing current word the _popup.Visible becomes false and nothing makes it true unless Reopen key is pressed.
Is this supposed to happen? Should we set the _popup.Visible = true whenever we try to render the suggestoins?
Metadata
Metadata
Assignees
Labels
Type
Projects
Status