diff --git a/.github/workflows/code_quality.yml b/.github/workflows/code_quality.yml index d67f182d3..aee4cef39 100644 --- a/.github/workflows/code_quality.yml +++ b/.github/workflows/code_quality.yml @@ -65,8 +65,6 @@ jobs: } }) - # Have a separate workflow because we don't want to enforce this at all - # It will have too many errors initially and is likely to deter contributors ruff-linting: name: Linting with ruff runs-on: ubuntu-latest @@ -81,10 +79,13 @@ jobs: run: pip install -e .[dev] - name: Run ruff linting shell: bash + id: ruff_lint continue-on-error: true run: | - ruff check - + if ! ruff check; then + echo "::warning title=ruff lint::Ruff found linting issues" + exit 78 # no longer works in github, but would mark action step with a warning + fi run-mypy: name: Run informational mypy diff --git a/ruff.toml b/ruff.toml index 5ac982706..dba8a0487 100644 --- a/ruff.toml +++ b/ruff.toml @@ -17,7 +17,7 @@ exclude = [ select = [ "B", # flake8-bugbear "I", # isort - # "ARG", # flake8-unused-arguments + "ARG", # flake8-unused-arguments "C4", # flake8-comprehensions "F401", # flake8-unused-imports "F541", # flake8 f-string without any placeholders