Skip to content

Commit 79085bf

Browse files
committed
complete the most of ImageResize tests
1 parent be2849b commit 79085bf

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

lib/ImageResize.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -667,7 +667,7 @@ protected function getCropPosition($expectedSize, $position = self::CROPCENTER)
667667
*
668668
* @param resource $image
669669
* @param integer $mode
670-
* @return integer|null
670+
* @return null
671671
*/
672672
public function imageFlip($image, $mode)
673673
{

test/ImageResizeTest.php

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -348,9 +348,14 @@ public function testCropLargerNotAllowed()
348348

349349
public function testImageFlip()
350350
{
351-
$image = $this->createImage(200, 100, 'png');
352-
$resize = new ImageResize($image);
353-
$resize->imageFlip();
351+
$imageFileName = $this->createImage(200, 100, 'png');
352+
$resize = new ImageResize($imageFileName);
353+
$image = imagecreatetruecolor(200, 100);
354+
355+
$this::assertNull($resize->imageFlip($image, 0));
356+
$this::assertNull($resize->imageFlip($image, 1));
357+
$this::assertNull($resize->imageFlip($image, 2));
358+
$this->assertNull($resize->imageFlip($image, 3));
354359
}
355360

356361
/**

0 commit comments

Comments
 (0)