Refactor password encoding to dedicated UserPasswordService

Author: gunkim

api/src/main/kotlin/io/github/gunkim/realworld/api/user/UsersController.kt

@@ -1,12 +1,12 @@
 package io.github.gunkim.realworld.api.user
 
 import io.github.gunkim.realworld.api.JsonRequest
-import io.github.gunkim.realworld.domain.user.service.AuthenticateUserService
-import io.github.gunkim.realworld.domain.user.service.CreateUserService
-import io.github.gunkim.realworld.domain.user.service.GetUserService
 import io.github.gunkim.realworld.api.user.model.request.UserAuthenticateRequest
 import io.github.gunkim.realworld.api.user.model.request.UserRegistrationRequest
 import io.github.gunkim.realworld.api.user.model.response.wrapper.UserWrapper
+import io.github.gunkim.realworld.domain.user.service.AuthenticateUserService
+import io.github.gunkim.realworld.domain.user.service.CreateUserService
+import io.github.gunkim.realworld.domain.user.service.GetUserService
 import org.springframework.web.bind.annotation.PostMapping
 import org.springframework.web.bind.annotation.RequestMapping
 import org.springframework.web.bind.annotation.RestController
@@ -37,7 +37,7 @@ class UsersController(
         val registeredUser = createUserService.createUser(
             email = request.email,
             username = request.username,
-            encodedPassword = authenticateUserService.encodePassword(request.password),
+            password = request.password,
         )
         return userResponseAssembler.assembleUserResponse(registeredUser)
             .let(::UserWrapper)
@@ -46,6 +46,7 @@ class UsersController(
     override fun authenticate(request: UserAuthenticateRequest): UserWrapper {
         val user = getUserService.getByEmail(request.email)
         authenticateUserService.authenticate(user, request.password)
+
         return userResponseAssembler.assembleUserResponse(user)
             .let(::UserWrapper)
     }

api/src/test/kotlin/io/github/gunkim/realworld/share/IntegrationTest.kt

@@ -80,7 +80,7 @@ abstract class IntegrationTest : FreeSpec() {
         val user = createUserService.createUser(
             email = email,
             username = username,
-            encodedPassword = authenticationUserService.encodePassword(password)
+            password = authenticationUserService.encodePassword(password)
         )
 
         return user to createTokenService.createToken(user.id).let(::toToken)

core/src/main/kotlin/io/github/gunkim/realworld/domain/user/service/AuthenticateUserService.kt

@@ -14,6 +14,4 @@ class AuthenticateUserService(
             InvalidUserPasswordException("Password does not match")
         }
     }
-
-    fun encodePassword(rawPassword: String): String = userPasswordService.encode(rawPassword)
 }

core/src/main/kotlin/io/github/gunkim/realworld/domain/user/service/CreateUserService.kt

@@ -1,20 +1,22 @@
 package io.github.gunkim.realworld.domain.user.service
 
+import io.github.gunkim.realworld.domain.auth.service.UserPasswordService
 import io.github.gunkim.realworld.domain.user.model.User
 import io.github.gunkim.realworld.domain.user.repository.UserRepository
 import org.springframework.stereotype.Service
 
 @Service
 class CreateUserService(
     private val userRepository: UserRepository,
+    private val userPasswordService: UserPasswordService,
 ) {
     fun createUser(
         email: String,
         username: String,
-        encodedPassword: String,
+        password: String,
     ) = User.create(
         email = email,
-        password = encodedPassword,
+        password = userPasswordService.encode(password),
         name = username
     ).let(userRepository::save)
 }