Raaise exceptions for missing required parameters

Author: gunthercox

chatterbot/logic/specific_response.py

@@ -20,7 +20,19 @@ class SpecificResponseAdapter(LogicAdapter):
     def __init__(self, chatbot, **kwargs):
         super().__init__(chatbot, **kwargs)
 
-        self.input_text = kwargs.get('input_text')
+        try:
+            self.input_text = kwargs['input_text']
+        except KeyError:
+            raise chatbot.ChatBotException(
+                'The SpecificResponseAdapter requires an input_text parameter.'
+            )
+
+        try:
+            self._output_text = kwargs['output_text']
+        except KeyError:
+            raise chatbot.ChatBotException(
+                'The SpecificResponseAdapter requires an output_text parameter.'
+            )
 
         self.matcher = None
 
@@ -33,8 +45,6 @@ def __init__(self, chatbot, **kwargs):
 
             self.matcher.add('SpecificResponse', [self.input_text])
 
-        self._output_text = kwargs.get('output_text')
-
     def _initialize_nlp(self, language):
         model = get_model_for_language(language)
 

tests/logic/test_specific_response.py

@@ -17,6 +17,26 @@ def setUp(self):
             output_text='Your sesame seed hamburger roll is now open.'
         )
 
+    def test_initialization_with_missing_input_text(self):
+        """"
+        Test that an exception is raised if input_text is missing.
+        """
+        with self.assertRaises(self.chatbot.ChatBotException):
+            SpecificResponseAdapter(
+                self.chatbot,
+                output_text='Done!'
+            )
+
+    def test_initialization_with_missing_output_text(self):
+        """"
+        Test that an exception is raised if output_text is missing.
+        """
+        with self.assertRaises(self.chatbot.ChatBotException):
+            SpecificResponseAdapter(
+                self.chatbot,
+                input_text='Do something!'
+            )
+
     def test_exact_match(self):
         """
         Test the case that an exact match is given.