Skip to content

Commit 0a4b030

Browse files
Add ESLint rule to disallow console.log
- Added the `no-console` ESLint rule to error on `console.log` statements while allowing `console.warn` and `console.error`. - Commented out existing `console.log` statements in most files to comply with the new rule. - Disabled the `no-console` rule for specific lines in `dev-server.ts` and `src_demo/index.ts` as these are development/demo tools where console logging is useful for debugging.
1 parent a5717f9 commit 0a4b030

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

src/CrystalQuartz.Application.Client2/dev/dev-server.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,8 @@ server.on('request', (request, response) => {
116116
const requestUrl = url.parse(request.url ?? '', true);
117117

118118
if (request.method === 'GET') {
119-
// console.log('GET', request.url);
119+
// eslint-disable-next-line no-console -- useful for debugging dev server requests
120+
console.log('GET', request.url);
120121

121122
const filePath = requestUrl.query.path ? 'dist/' + requestUrl.query.path : 'dist/index.html';
122123

@@ -135,7 +136,8 @@ server.on('request', (request, response) => {
135136
data = data.toString();
136137
const POST = querystring.parse(data);
137138

138-
// console.log('POST', POST);
139+
// eslint-disable-next-line no-console -- useful for debugging dev server requests
140+
console.log('POST', POST);
139141

140142
const result = schedulerServer.handleRequest(POST);
141143
response.writeHead(200, { 'Content-Type': 'application/json' });

src/CrystalQuartz.Application.Client2/src_demo/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ const schedulerServer = new FakeSchedulerServer({
8484
version: options.version,
8585
});
8686

87-
// const log = console.log || (() => {});
87+
const log = console.log || (() => {}); // eslint-disable-line no-console -- useful for debugging demo client requests
8888

8989
const parseBody = (body: BodyInit | null | undefined) => {
9090
if (body === null || body === undefined) {
@@ -101,14 +101,14 @@ const parseBody = (body: BodyInit | null | undefined) => {
101101
window.fetch = async function (input: RequestInfo | URL, init?: RequestInit): Promise<Response> {
102102
const data = parseBody(init?.body);
103103

104-
log('fetch request intercepted:', data);
104+
log('fetch request intercepted:', data); // eslint-disable-line no-console -- useful for debugging demo client requests
105105

106106
// Simulate network delay
107107
await new Promise((resolve) => setTimeout(resolve, 1000));
108108

109109
const result = schedulerServer.handleRequest(data);
110110

111-
log('fetch response:', result);
111+
log('fetch response:', result); // eslint-disable-line no-console -- useful for debugging demo client requests
112112

113113
return new Response(JSON.stringify(result), {
114114
status: 200,

0 commit comments

Comments
 (0)