New frontend: code cleanup

Author: guryanovev

src/CrystalQuartz.Application.Client2/dev/fake-scheduler-server.ts

@@ -75,7 +75,7 @@ export default [
   {
     languageOptions: {
       parserOptions: {
-        project: './tsconfig.json',
+        project: './tsconfig.eslint.json',
       },
     },
     files: ['**/*.ts', '**/*.tsx'],

src/CrystalQuartz.Application.Client2/dev/fake-scheduler.ts

@@ -211,19 +211,9 @@ export interface TriggerDetails {
 }
 
 export class NullableDate {
-  private readonly _isEmpty: boolean;
+  public readonly isEmpty = this.date == null;
 
-  public constructor(private readonly date: number | null) {
-    this._isEmpty = date == null;
-  }
-
-  public isEmpty(): boolean {
-    return this._isEmpty;
-  }
-
-  public getDate(): number | null {
-    return this.date;
-  }
+  public constructor(public readonly date: number | null) {}
 }
 
 export class ErrorMessage {

src/CrystalQuartz.Application.Client2/eslint.config.mjs

@@ -8,7 +8,7 @@ import ViewModel from './scheduler-details-view-model';
 import SchedulerDetailsViewModel from './scheduler-details-view-model';
 
 export default class SchedulerDetailsView extends ViewBase<ViewModel> {
-  constructor(viewModel: SchedulerDetailsViewModel) {
+  public constructor(viewModel: SchedulerDetailsViewModel) {
     super(viewModel, 'Scheduler Details');
   }
 

src/CrystalQuartz.Application.Client2/src/api/index.ts

@@ -8,17 +8,12 @@ import { PropertyView } from '../common/property-view';
 import DialogViewBase from '../dialog-view-base';
 import { TriggerDetailsViewModel } from './trigger-details-view-model';
 
-// import TEMPLATE from './trigger-details.tmpl.html';
-
-// import { RENDER_PROPERTIES } from '../common/object-browser';
-// import { CHANGE_DOM_DISPLAY } from "../schedule-job/steps/view-commons";
-
 export class TriggerDetailsView extends DialogViewBase<TriggerDetailsViewModel> implements OnInit {
-  constructor(viewModel: TriggerDetailsViewModel) {
+  public constructor(viewModel: TriggerDetailsViewModel) {
     super(viewModel, 'Trigger Details');
   }
 
-  onInit(root: DomElement | null, domEngine: DomEngine): OptionalDisposables {
+  public onInit(root: DomElement | null, domEngine: DomEngine): OptionalDisposables {
     this.viewModel.loadDetails();
 
     return super.onInit(root, domEngine);
@@ -81,29 +76,4 @@ export class TriggerDetailsView extends DialogViewBase<TriggerDetailsViewModel>
       </div>
     );
   }
-
-  // template = TEMPLATE;
-  //
-  // init(dom: js.IDom, viewModel:TriggerDetailsViewModel) {
-  //     super.init(dom, viewModel);
-  //
-  //     const stateUi = [
-  //         { code: 'unknown', dom: dom('.js_stateUnknown') },
-  //         { code: 'error', dom: dom('.js_stateError') },
-  //         { code: 'ready', dom: dom('.js_stateReady') }
-  //     ];
-  //
-  //     dom.manager.manage(viewModel.state.listen(state => {
-  //         CHANGE_DOM_DISPLAY(stateUi, state.toString());
-  //     }));
-  //
-  //     dom('.js_summary').observes(viewModel.summary, PropertyView);
-  //     dom('.js_identity').observes(viewModel.identity, PropertyView);
-  //     dom('.js_schedule').observes(viewModel.schedule, PropertyView);
-  //     dom('.js_stateError').observes(viewModel.errorMessage);
-  //
-  //     RENDER_PROPERTIES(dom('.js_jobDataMap'), viewModel.jobDataMap);
-  //
-  //     viewModel.loadDetails();
-  // }
 }

src/CrystalQuartz.Application.Client2/src/dialogs/scheduler-details/scheduler-details-view.tsx

@@ -3,9 +3,9 @@ import Action from './action';
 import Separator from './separator';
 
 export default class ActionView implements View {
-  constructor(private readonly action: Action | Separator) {}
+  public constructor(private readonly action: Action | Separator) {}
 
-  template(): HtmlDefinition {
+  public template(): HtmlDefinition {
     const action = this.action;
     if (action instanceof Separator) {
       return (

src/CrystalQuartz.Application.Client2/src/dialogs/trigger-details/trigger-details-view.tsx

@@ -1,5 +1,5 @@
 import { View } from 'john-smith/view';
 
 export default class SeparatorView implements View {
-  template = () => <li role="separator" class="divider"></li>;
+  public template = () => <li role="separator" class="divider"></li>;
 }

src/CrystalQuartz.Application.Client2/src/global/actions/action-view.tsx

@@ -8,9 +8,9 @@ const statusData: Record<ActivityState, { title: string; className: string }> =
 };
 
 export class ActivityStateView implements View {
-  constructor(private readonly viewModel: ActivityState) {}
+  public constructor(private readonly viewModel: ActivityState) {}
 
-  template(): HtmlDefinition {
+  public template(): HtmlDefinition {
     const statusDataValue = statusData[this.viewModel];
 
     return (