Fixed sync IO issue on 404 response, added support for readonly mode on backend side

Author: guryanovev

src/CommonAssemblyInfo.cs

@@ -10,5 +10,5 @@
 using System.Reflection;
 
 [assembly: AssemblyProductAttribute("CrystalQuartz")]
-[assembly: AssemblyVersionAttribute("7.2.0.0")]
-[assembly: AssemblyFileVersionAttribute("7.2.0.0")]
+[assembly: AssemblyVersionAttribute("7.3.0.0")]
+[assembly: AssemblyFileVersionAttribute("7.3.0.0")]

src/CrystalQuartz.Application/CrystalQuartzOptions.cs

@@ -77,6 +77,8 @@ public static RegisteredInputType[] CreateDefaultJobDataMapInputTypes()
         public Type[]? AllowedJobTypes { get; set; }
 
         public Action<Exception>? OnUnhandledPanelException { get; set; }
+
+        public bool ReadOnly { get; set; } = false;
     }
 
     public class ConfigurableTraversingOptions

src/CrystalQuartz.Application/SchedulerHostInitializer.cs

@@ -148,9 +148,13 @@ private async Task<SchedulerHost> CreateSchedulerHostInternal()
                 services.EventSource.EventEmitted += (sender, args) => { eventHub.Push(args.Payload); };
             }
 
+            ISchedulerCommander schedulerCommander = _options.ReadOnly
+                ? new ReadOnlySchedulerCommander()
+                : services.Commander;
+
             return new ReadySchedulerHost(
                 services.Clerk,
-                services.Commander,
+                schedulerCommander,
                 quartzVersion,
                 eventHub,
                 eventHub,

src/CrystalQuartz.Application/Startup/OptionsUtils.cs

@@ -38,7 +38,8 @@ public static Options ToRuntimeOptions(
                 jobResultAnalyzer,
                 options.JobDataMapInputTypes,
                 options.AllowedJobTypes ?? new Type[0],
-                options.OnUnhandledPanelException);
+                options.OnUnhandledPanelException,
+                options.ReadOnly);
         }
 
         private static IJobResultAnalyzer CreateJobResultAnalyzer(JobResultAnalyserOptions options)

src/CrystalQuartz.Core/Contracts/ReadOnlySchedulerCommander.cs

@@ -0,0 +1,60 @@
+namespace CrystalQuartz.Core.Contracts
+{
+    using System;
+    using System.Collections.Generic;
+    using System.Threading.Tasks;
+    using CrystalQuartz.Core.Domain.TriggerTypes;
+
+    public class ReadOnlySchedulerCommander : ISchedulerCommander
+    {
+        public Task ScheduleJob(
+            string jobName,
+            string jobGroup,
+            string? triggerName,
+            TriggerType trigger,
+            IDictionary<string, object>? jobData) => Fail();
+
+        public Task ScheduleJob(
+            string? jobName,
+            string? jobGroup,
+            Type jobType,
+            string? triggerName,
+            TriggerType triggerType,
+            IDictionary<string, object>? jobData) => Fail();
+
+        public Task DeleteJobGroup(string jobGroup) => Fail();
+
+        public Task DeleteJob(string jobName, string jobGroup) => Fail();
+
+        public Task DeleteTrigger(string triggerName, string triggerGroup) => Fail();
+
+        public Task ExecuteNow(string jobName, string jobGroup) => Fail();
+
+        public Task PauseAllJobs() => Fail();
+
+        public Task PauseJobGroup(string jobGroup) => Fail();
+
+        public Task PauseJob(string jobName, string jobGroup) => Fail();
+
+        public Task PauseTrigger(string triggerName, string triggerGroup) => Fail();
+
+        public Task ResumeAllJobs() => Fail();
+
+        public Task ResumeJobGroup(string jobGroup) => Fail();
+
+        public Task ResumeJob(string jobName, string jobGroup) => Fail();
+
+        public Task ResumeTrigger(string triggerName, string triggerGroup) => Fail();
+
+        public Task StandbyScheduler() => Fail();
+
+        public Task StartScheduler() => Fail();
+
+        public Task StopScheduler() => Fail();
+
+        private Task Fail()
+        {
+            throw new Exception("Could not perform this action, the scheduler is read-only.");
+        }
+    }
+}

src/CrystalQuartz.Core/Options.cs

@@ -26,7 +26,8 @@ public Options(
             IJobResultAnalyzer jobResultAnalyzer,
             RegisteredInputType[] jobDataMapInputTypes,
             Type[] allowedJobTypes,
-            Action<Exception> errorAction)
+            Action<Exception> errorAction,
+            bool readOnly)
         {
             TimelineSpan = timelineSpan;
             SchedulerEngineResolvers = schedulerEngineResolvers;
@@ -41,6 +42,7 @@ public Options(
             JobDataMapInputTypes = jobDataMapInputTypes;
             AllowedJobTypes = allowedJobTypes;
             ErrorAction = errorAction;
+            ReadOnly = readOnly;
         }
 
         public TimeSpan TimelineSpan { get; }
@@ -68,5 +70,7 @@ public Options(
         public Type[] AllowedJobTypes { get; }
 
         public Action<Exception> ErrorAction { get; }
+
+        public bool ReadOnly { get; }
     }
 }

src/CrystalQuartz.WebFramework/Request/AbstractFileRequestHandler.cs

@@ -26,7 +26,11 @@ public RequestHandlingResult WriteResourceToStream(string resourceName, IRequest
                     404,
                     async stream =>
                     {
+#if NETSTANDARD2_1_OR_GREATER
+                        await using var output = new StreamWriter(stream);
+#else
                         using var output = new StreamWriter(stream);
+#endif
                         await output.WriteLineAsync("Not found");
                     }));
             }

src/CrystalQuartz.WebFramework/Request/FileRequestHandler.cs

@@ -12,7 +12,7 @@ public FileRequestHandler(Assembly resourcesAssembly, string resourcePrefix)
 
         protected override string? GetPath(IRequest request)
         {
-            return request["path"];
+            return request["path"]?.TrimStart('/'); // We only need this Trim call because of the bug https://github.com/jantimon/html-webpack-plugin/issues/694
         }
     }
 }

src/Demo.Quartz3.DotNetCore3/Program.cs

@@ -5,6 +5,7 @@ namespace Demo.Quartz3.DotNetCore3
     using System.Collections.Generic;
     using System.Collections.Specialized;
     using System.Threading.Tasks;
+    using CrystalQuartz.Application;
     using CrystalQuartz.AspNetCore;
     using Microsoft.AspNetCore;
     using Microsoft.AspNetCore.Hosting;
@@ -21,7 +22,7 @@ static async Task Main(string[] args)
                 .CreateDefaultBuilder()
                 .Configure(app =>
                 {
-                    app.UseCrystalQuartz(() => scheduler); 
+                    app.UseCrystalQuartz(() => scheduler, new CrystalQuartzOptions { ReadOnly = true }); 
                 });
 
             await builder.Build().RunAsync();