Add explicit public modifiers to dialog members (partial 2)

This change continues adding explicit `public` modifiers to class members (fields, constructors, and methods) in TypeScript files within the `src/CrystalQuartz.Application.Client2/src/dialogs` directory.

This is part of a larger effort to improve code clarity and explicitness.

Completed steps in this phase:
- Modified `src/CrystalQuartz.Application.Client2/src/dialogs/dialog-view-base.tsx`
- Modified `src/CrystalQuartz.Application.Client2/src/dialogs/dialog-view-model.ts`
- Modified `src/CrystalQuartz.Application.Client2/src/dialogs/job-details/job-details-view-model.ts`
- Modified `src/CrystalQuartz.Application.Client2/src/dialogs/schedule-job/schedule-job-view-model.ts`
- Modified `src/CrystalQuartz.Application.Client2/src/dialogs/schedule-job/steps/group-configuration-step.ts`

Previously completed steps for this directory are in the commit for branch `feature/public-dialog-modifiers-partial`.

Author: google-labs-jules[bot]

src/CrystalQuartz.Application.Client2/src/dialogs/dialog-view-base.tsx

@@ -25,7 +25,7 @@ export default abstract class DialogViewBase<T extends IDialogViewModel<any>>
     }
   }
 
-  template(): HtmlDefinition {
+  public template(): HtmlDefinition {
     console.log('template', this.viewModel);
 
     return (

src/CrystalQuartz.Application.Client2/src/dialogs/dialog-view-model.ts

@@ -10,16 +10,16 @@ export interface IDialogViewModel<TResult> {
 }
 
 export class DialogViewModel<TResult> implements IDialogViewModel<TResult> {
-  accepted = new Event<any>();
-  canceled = new Event<any>();
-  state = new ObservableValue<DataState>('unknown');
-  errorMessage = new ObservableValue<string | null>(null);
+  public accepted = new Event<any>();
+  public canceled = new Event<any>();
+  public state = new ObservableValue<DataState>('unknown');
+  public errorMessage = new ObservableValue<string | null>(null);
 
-  constructor() {
+  public constructor() {
     this.state.setValue('unknown');
   }
 
-  cancel() {
+  public cancel() {
     this.canceled.trigger({});
   }
 

src/CrystalQuartz.Application.Client2/src/dialogs/job-details/job-details-view-model.ts

@@ -6,18 +6,18 @@ import { Property, PropertyType } from '../common/property';
 import { DialogViewModel } from '../dialog-view-model';
 
 export default class JobDetailsViewModel extends DialogViewModel<any> {
-  summary = new ObservableList<Property>();
-  identity = new ObservableList<Property>();
-  jobDataMap = new ObservableValue<PropertyValue | null>(null);
+  public summary = new ObservableList<Property>();
+  public identity = new ObservableList<Property>();
+  public jobDataMap = new ObservableValue<PropertyValue | null>(null);
 
-  constructor(
+  public constructor(
     private job: Job,
     private commandService: CommandService
   ) {
     super();
   }
 
-  loadDetails() {
+  public loadDetails() {
     this.commandService
       .executeCommand<JobDetails>(new GetJobDetailsCommand(this.job.GroupName, this.job.Name), true)
       .then((details) => {

src/CrystalQuartz.Application.Client2/src/dialogs/schedule-job/schedule-job-view-model.ts

@@ -38,18 +38,18 @@ export class ScheduleJobViewModel /*extends Owner*/ implements IDialogViewModel<
   private _currentData!: ConfigurationStepData;
   private _finalStep: TriggerConfigurationStep;
 
-  isSaving = new ObservableValue<boolean>(false);
+  public isSaving = new ObservableValue<boolean>(false);
 
-  currentStep = new ObservableValue<ConfigurationStep | null>(null);
-  previousStep = new ObservableValue<ConfigurationStep | null>(null);
-  nextStep = new ObservableValue<ConfigurationStep | null>(null);
+  public currentStep = new ObservableValue<ConfigurationStep | null>(null);
+  public previousStep = new ObservableValue<ConfigurationStep | null>(null);
+  public nextStep = new ObservableValue<ConfigurationStep | null>(null);
 
-  state = new ObservableValue<string | null>(null);
+  public state = new ObservableValue<string | null>(null);
 
-  accepted = new Event<any>(); /* todo: base class */
-  canceled = new Event<any>();
+  public accepted = new Event<any>(); /* todo: base class */
+  public canceled = new Event<any>();
 
-  constructor(
+  public constructor(
     private schedulerExplorer: SchedulerExplorer,
     private commandService: CommandService,
     private options: ScheduleJobOptions = {}
@@ -89,21 +89,21 @@ export class ScheduleJobViewModel /*extends Owner*/ implements IDialogViewModel<
     this.state.setValue(ConfigarationState.Ready);
   }
 
-  initState(): void {
+  public initState(): void {
     this.state.setValue(ConfigarationState.Loading);
 
     this.commandService.executeCommand(new GetJobTypesCommand()).then((data) => {
       this.initConfigSteps(data);
     });
   }
 
-  releaseState() {}
+  public releaseState() {}
 
-  cancel() {
+  public cancel() {
     this.canceled.trigger({});
   }
 
-  goBackOrCancel() {
+  public goBackOrCancel() {
     const previousStep = this.previousStep.getValue();
     if (previousStep) {
       this.setCurrentStep(this.previousStep.getValue()!);
@@ -112,7 +112,7 @@ export class ScheduleJobViewModel /*extends Owner*/ implements IDialogViewModel<
     }
   }
 
-  goNextOrSave() {
+  public goNextOrSave() {
     const currentStep = this.currentStep.getValue();
     if (currentStep && currentStep.validators && !currentStep.validators.validate()) {
       return false;

src/CrystalQuartz.Application.Client2/src/dialogs/schedule-job/steps/group-configuration-step.ts

@@ -15,18 +15,18 @@ export class JobGroupType {
 }
 
 export class GroupConfigurationStep /*extends Owner*/ implements ConfigurationStep {
-  code = 'group';
-  navigationLabel = 'Configure Group';
+  public code = 'group';
+  public navigationLabel = 'Configure Group';
 
-  jobGroupType = new BidirectionalValue<string>((value) => true, JobGroupType.None);
-  jobGroupTypeOptions = new ObservableList<SelectOption>();
-  existingJobGroups = new ObservableList<SelectOption>();
-  selectedJobGroup = new BidirectionalValue<string>((value) => true, '');
-  newJobGroup = new BidirectionalValue<string>((value) => true, '');
+  public jobGroupType = new BidirectionalValue<string>((value) => true, JobGroupType.None);
+  public jobGroupTypeOptions = new ObservableList<SelectOption>();
+  public existingJobGroups = new ObservableList<SelectOption>();
+  public selectedJobGroup = new BidirectionalValue<string>((value) => true, '');
+  public newJobGroup = new BidirectionalValue<string>((value) => true, '');
 
-  validators = new Validators();
+  public validators = new Validators();
 
-  constructor(private schedulerExplorer: SchedulerExplorer) {
+  public constructor(private schedulerExplorer: SchedulerExplorer) {
     // super();
 
     const groups = schedulerExplorer.listGroups().map((g) => ({ value: g.Name, title: g.Name }));
@@ -56,7 +56,7 @@ export class GroupConfigurationStep /*extends Owner*/ implements ConfigurationSt
     //this.own(this.validators);
   }
 
-  onEnter(data: ConfigurationStepData): ConfigurationStepData {
+  public onEnter(data: ConfigurationStepData): ConfigurationStepData {
     // workarounds for selects caused by the fact that the value is set before
     // options rendered
     this.jobGroupType.mutate((_) => _);
@@ -65,15 +65,15 @@ export class GroupConfigurationStep /*extends Owner*/ implements ConfigurationSt
     return data;
   }
 
-  onLeave(data: ConfigurationStepData): ConfigurationStepData {
+  public onLeave(data: ConfigurationStepData): ConfigurationStepData {
     return {
       groupName: this.getGroupName(),
       jobClass: data.jobClass,
       jobName: data.jobName,
     };
   }
 
-  getGroupName(): string | null {
+  public getGroupName(): string | null {
     const jobGroupType = this.jobGroupType.getValue();
 
     if (jobGroupType === JobGroupType.None) {
@@ -87,7 +87,7 @@ export class GroupConfigurationStep /*extends Owner*/ implements ConfigurationSt
     return null;
   }
 
-  releaseState() {
+  public releaseState() {
     //this.dispose();
   }
 }