Skip to content

Commit 6e3a841

Browse files
committed
Corrected direction of convexity adjustment
1 parent e799804 commit 6e3a841

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pyacm/acm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@ def _expected_return(self):
445445
# Historical estimate
446446
exp_ret = (self.B @ (self.lambda1 @ self.pc_factors_d.T + self.lambda0.reshape(-1, 1))).values
447447
conv_adj = np.diag(self.B @ self.Sigma @ self.B.T) + self.omega[0, 0]
448-
er_hist = (exp_ret + conv_adj[:, None]).T
448+
er_hist = (exp_ret - 0.5 * conv_adj[:, None]).T
449449
er_hist_d = pd.DataFrame(
450450
data=er_hist,
451451
index=self.pc_factors_d.index,

0 commit comments

Comments
 (0)