Merge pull request #12 from cordoval/improvements

General Improvements (PSR4, MetaData, Travis)

Author: Richtermeister

.gitignore

@@ -1,4 +1,3 @@
-/phpunit.xml
-*~
+phpunit.xml
 composer.lock
-/vendor/
+/vendor

.travis.yml

@@ -4,6 +4,5 @@ php:
   - 5.3
   - 5.4
 
-before_script:
-    - curl -s http://getcomposer.org/installer | php
-    - php composer.phar install --dev
+install:
+  - composer install

Converter/MissingParamException.php

@@ -1,4 +1,5 @@
 <?php
+
 /*
  * This file is part of ToInlineStyleEmailBundle.
  *
@@ -15,6 +16,7 @@
  *
  * @author Roberto Trunfio <[email protected]>
  */
-class MissingParamException extends \Exception {
+class MissingParamException extends \Exception
+{
 
 }

Converter/MissingTemplatingEngineException.php

@@ -1,4 +1,5 @@
 <?php
+
 /*
  * This file is part of ToInlineStyleEmailBundle.
  *
@@ -15,6 +16,7 @@
  *
  * @author Roberto Trunfio <[email protected]>
  */
-class MissingTemplatingEngineException extends \Exception {
+class MissingTemplatingEngineException extends \Exception
+{
 
 }

Converter/ToInlineStyleEmailConverter.php

@@ -1,4 +1,5 @@
 <?php
+
 /*
  * This file is part of ToInlineStyleEmailBundle.
  *
@@ -25,8 +26,8 @@
  *
  * @author Roberto Trunfio <[email protected]>
  */
-class ToInlineStyleEmailConverter {
-
+class ToInlineStyleEmailConverter
+{
     /**
      * Container is used to get template engine instead of direct injection.
      * Direct injection is not used to avoid circular reference exception when rendering using twig tag

DependencyInjection/Configuration.php

@@ -1,27 +1,28 @@
 <?php
 
+/*
+ * This file is part of ToInlineStyleEmailBundle.
+ *
+ * (c) Roberto Trunfio <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 namespace RobertoTru\ToInlineStyleEmailBundle\DependencyInjection;
 
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\HttpKernel\DependencyInjection\Extension;
 use Symfony\Component\DependencyInjection\Loader;
 
-/**
- * This is the class that loads and manages your bundle configuration
- *
- * To learn more see {@link http://symfony.com/doc/current/cookbook/bundles/extension.html}
- */
 class RobertoTruToInlineStyleEmailExtension extends Extension
 {
     /**
      * {@inheritDoc}
      */
     public function load(array $configs, ContainerBuilder $container)
     {
-        $configuration = new Configuration();
-        $config = $this->processConfiguration($configuration, $configs);
-
         $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
         $loader->load('services.xml');
     }

DependencyInjection/RobertoTruToInlineStyleEmailExtension.php

@@ -4,18 +4,17 @@ ToInlineStyleEmailBundle
 **ToInlineStyleEmailBundle** is a _Symfony2_ bundle to use the **CssToInlineStyles** translator by _Tijs Verkoyen_ (see
 https://github.com/tijsverkoyen/CssToInlineStyles for the repository)
 
-
 Requirements
-===========
+============
 **ToInlineStyleEmailBundle** is only supported on **PHP 5.3.3** and up.
 
 Installation
-===========
+============
 Please, use the _Composer_ to install this bundle in your Symfony2 app. 
 
 The following lines should be added in your ```composer.json```
 
-```
+``` json
 "require": {
     "robertotru/to-inline-style-email-bundle": "dev-master"
 },
@@ -28,7 +27,7 @@ new RobertoTru\ToInlineStyleEmailBundle\RobertoTruToInlineStyleEmailBundle(),
 ```
 
 Documentation and Examples
-===========
+==========================
 The bundle provides a service named **css_to_inline_email_converter**. Use it in a controller to have a nice shortcut to the 
 converter developed by _Tijs Verkoyen_. E.g.:
 
@@ -91,10 +90,10 @@ Paths relative to bundle are supported as well:
 Read the docs in the files for further details on the usage of the service. 
 
 Contributing
-===========
+============
 **ToInlineStyleEmailBundle** is an open source project. Contributions are encouraged. 
 Feel free to contribute to improve this bundle.
 
 About the author of the bundle
-===========
-**ToInlineStyleEmailBundle** has been originally developed and is mantained by Roberto Trunfio (see more on the author at www.trunfio.it)
+==============================
+**ToInlineStyleEmailBundle** has been originally developed and is maintained by Roberto Trunfio (see more on the author at www.trunfio.it)

README.md

@@ -1,16 +1,22 @@
 <?php
 
+/*
+ * This file is part of ToInlineStyleEmailBundle.
+ *
+ * (c) Roberto Trunfio <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
 namespace RobertoTru\ToInlineStyleEmailBundle\Tests;
 
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 
-class ToInlineStyleEmailBundleTest extends WebTestCase {
-    public function testIndex() {
-
-        //$client = static::createClient();
-
-        //$crawler = $client->request('GET', '/hello/Fabien');
+class ToInlineStyleEmailBundleTest extends WebTestCase
+{
+    public function testIndex()
+    {
 
-        //$this->assertTrue($crawler->filter('html:contains("Hello Fabien")')->count() > 0);
     }
 }