Skip to content

Commit 74ab9c6

Browse files
committed
clean-up code
1 parent 729d28b commit 74ab9c6

File tree

2 files changed

+8
-13
lines changed

2 files changed

+8
-13
lines changed

src/test/java/com/geckotechnology/simpleCircuitBreaker/DisabledStateTest.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,11 @@ public void test() {
2121
public void run() {
2222
for(int i = 0; i<LOOP_COUNT; i++) {
2323
assertTrue(circuitBreaker.getBreakerState() instanceof BreakerDisabledState);
24-
if(circuitBreaker.isClosedForThisCall()) {
25-
assertTrue(circuitBreaker.getBreakerState() instanceof BreakerDisabledState);
26-
TestUtils.sleep(SLEEP_TIME);
27-
circuitBreaker.callSucceeded(SLEEP_TIME);
28-
}
29-
else
30-
fail("circuitBreaker should always be closed");
24+
assertTrue(circuitBreaker.isClosedForThisCall());
25+
assertTrue(circuitBreaker.getBreakerState() instanceof BreakerDisabledState);
26+
TestUtils.sleep(SLEEP_TIME);
27+
circuitBreaker.callSucceeded(SLEEP_TIME);
28+
assertTrue(circuitBreaker.getBreakerState() instanceof BreakerDisabledState);
3129
}
3230
}
3331
};

src/test/java/com/geckotechnology/simpleCircuitBreaker/ForceOpenStateTest.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,9 @@ public void test() {
2121
public void run() {
2222
for(int i = 0; i<LOOP_COUNT; i++) {
2323
assertTrue(circuitBreaker.getBreakerState() instanceof BreakerForcedOpenState);
24-
if(circuitBreaker.isClosedForThisCall())
25-
fail("circuitBreaker should always be closed");
26-
else {
27-
assertTrue(circuitBreaker.getBreakerState() instanceof BreakerForcedOpenState);
28-
TestUtils.sleep(SLEEP_TIME);
29-
}
24+
assertFalse(circuitBreaker.isClosedForThisCall());
25+
assertTrue(circuitBreaker.getBreakerState() instanceof BreakerForcedOpenState);
26+
TestUtils.sleep(SLEEP_TIME);
3027
}
3128
}
3229
};

0 commit comments

Comments
 (0)