Skip to content

Commit 38ff11a

Browse files
committed
Fixing request for merges testing issues
- made request_fetch use read only remotes so it does not break in travis - upated cassette for request list so namespace and repo path are differenciated
1 parent ebbaf4b commit 38ff11a

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

git_repo/services/ext/github.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ def request_list(self, user, repo):
8585
for pull in repository.iter_pulls():
8686
yield ( pull.number, pull.title, pull.links['issue'] )
8787

88-
def request_fetch(self, user, repo, request, pull=False): #pragma: no cover
88+
def request_fetch(self, user, repo, request, pull=False):
8989
if pull:
9090
raise NotImplementedError('Pull operation on requests for merge are not yet supported')
9191
log.info('remotes: {}'.format(self.repository.remotes))

tests/helpers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,7 @@ def action_request_list(self, cassette_name, namespace, repository, rq_list_data
450450
def action_request_fetch(self, cassette_name, namespace, repository, request, pull=False):
451451
with self.recorder.use_cassette('_'.join(['test', self.service.name, cassette_name])):
452452
self.service.connect()
453-
self.service.clone(namespace, repository)
453+
self.service.clone(namespace, repository, rw=False)
454454
self.service.request_fetch(repository, namespace, request)
455455
assert self.repository.branches[-1].name == 'request-{}'.format(request)
456456

tests/integration/cassettes/test_github_test_14_request_list.json

Lines changed: 7 additions & 7 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)