Skip to content

Commit 993db9b

Browse files
guzman109claude
andcommitted
fix(ci): use clang-18 from ubuntu-24.04 native repos, drop data artifact
- Remove LLVM apt repo setup, clang-18 is available natively on ubuntu-24.04 - Switch all clang-21 references to clang-18 with matching Conan version - Remove data/** from artifact upload path Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent e840ebe commit 993db9b

File tree

2 files changed

+28
-22
lines changed

2 files changed

+28
-22
lines changed

.github/workflows/build.yaml

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -20,18 +20,16 @@ jobs:
2020

2121
- name: Install system build tools
2222
run: |
23-
wget -qO- https://apt.llvm.org/llvm-snapshot.gpg.key | sudo tee /etc/apt/trusted.gpg.d/apt.llvm.org.asc
24-
echo "deb http://apt.llvm.org/noble/ llvm-toolchain-noble-21 main" | sudo tee /etc/apt/sources.list.d/llvm-21.list
2523
sudo apt-get update
2624
sudo apt-get install -y \
2725
cmake ninja-build git pkg-config \
28-
clang-21 lld-21 \
29-
libc++-21-dev libc++abi-21-dev \
26+
clang-18 lld-18 \
27+
libc++-18-dev libc++abi-18-dev \
3028
curl ca-certificates \
3129
meson
32-
sudo ln -sf /usr/bin/clang-21 /usr/bin/clang
33-
sudo ln -sf /usr/bin/clang++-21 /usr/bin/clang++
34-
clang++-21 --version
30+
sudo ln -sf /usr/bin/clang-18 /usr/bin/clang
31+
sudo ln -sf /usr/bin/clang++-18 /usr/bin/clang++
32+
clang++-18 --version
3533
3634
- name: Install Conan
3735
uses: conan-io/setup-conan@v1
@@ -40,22 +38,22 @@ jobs:
4038

4139
- name: Conan install
4240
env:
43-
CC: clang-21
44-
CXX: clang++-21
41+
CC: clang-18
42+
CXX: clang++-18
4543
run: |
4644
conan install . \
4745
--build=missing \
4846
-s build_type=Release \
4947
-s compiler=clang \
50-
-s compiler.version=21 \
48+
-s compiler.version=18 \
5149
-s compiler.libcxx=libc++ \
5250
-s compiler.cppstd=23 \
5351
-of build
5452
5553
- name: Configure (CMake + Conan toolchain)
5654
env:
57-
CC: clang-21
58-
CXX: clang++-21
55+
CC: clang-18
56+
CXX: clang++-18
5957
run: |
6058
cmake -S . -B build -G Ninja \
6159
-DCMAKE_BUILD_TYPE=Release \
@@ -76,7 +74,6 @@ jobs:
7674
name: icicle-insights-linux-amd64
7775
path: |
7876
build/icicle-insights
79-
data/**
8077
if-no-files-found: error
8178

8279
docker:

justfile

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,16 +39,25 @@ run:
3939
{{ BUILD_DIR }}/icicle-insights
4040

4141
docker-build:
42-
docker buildx build --platform linux/amd64 -t ghcr.io/icicle-ai/insights:latest .
42+
docker buildx build --platform linux/amd64 -t ghcr.io/icicle-ai/insights:latest .
4343

4444
docker-run:
45-
docker run -itd -p 3000:3000 --env-file=.env --name insights ghcr.io/icicle-ai/insights:latest
45+
docker run -itd -p 3000:3000 --env-file=.env --name insights ghcr.io/icicle-ai/insights:latest
4646

4747
act-build:
48-
act -j docker \
49-
--container-architecture linux/amd64 \
50-
-P ubuntu-24.04=ghcr.io/catthehacker/ubuntu:act-24.04 \
51-
--secret GITHUB_TOKEN="$(gh auth token)" \
52-
--env SSL_CERT_FILE= \
53-
--env CURL_CA_BUNDLE= \
54-
--env REQUESTS_CA_BUNDLE=
48+
act -j docker \
49+
--container-architecture linux/amd64 \
50+
-P ubuntu-24.04=ghcr.io/catthehacker/ubuntu:act-24.04 \
51+
--secret GITHUB_TOKEN="$(gh auth token)" \
52+
--env SSL_CERT_FILE= \
53+
--env CURL_CA_BUNDLE= \
54+
--env REQUESTS_CA_BUNDLE=
55+
56+
act-linux:
57+
act -j linux \
58+
--container-architecture linux/amd64 \
59+
-P ubuntu-24.04=ghcr.io/catthehacker/ubuntu:act-24.04 \
60+
--secret GITHUB_TOKEN="$(gh auth token)" \
61+
--env SSL_CERT_FILE= \
62+
--env CURL_CA_BUNDLE= \
63+
--env REQUESTS_CA_BUNDLE=

0 commit comments

Comments
 (0)