update

Author: moqsien

internal/luapi/plugin/fromlua.go

@@ -8,12 +8,14 @@ import (
 type LuaConfItem string
 
 const (
-	SDKName       LuaConfItem = "sdk_name"
-	PluginName    LuaConfItem = "plugin_name"
-	PluginVersion LuaConfItem = "plugin_version"
-	Prequisite    LuaConfItem = "prequisite"
-	Homepage      LuaConfItem = "homepage"
-	Crawler       LuaConfItem = "crawl"
+	SDKName         LuaConfItem = "sdk_name"
+	PluginName      LuaConfItem = "plugin_name"
+	PluginVersion   LuaConfItem = "plugin_version"
+	Prequisite      LuaConfItem = "prequisite"
+	Homepage        LuaConfItem = "homepage"
+	Crawler         LuaConfItem = "crawl"
+	PostInstall     LuaConfItem = "postInstall" // optional
+	CustomedInstall LuaConfItem = "install"     // optional
 )
 
 var InstallerConfig LuaConfItem = LuaConfItem(lua_global.InstallerConfigName)

internal/luapi/plugin/fromlua_test.go

@@ -50,3 +50,35 @@ func TestGetLuaConfItem(t *testing.T) {
 		assert.Equal(t, noneShouldBe, s, fmt.Sprintf("none should be: %s", noneShouldBe))
 	}
 }
+
+var postInstallHandlerScript = `
+function postInstall(installed_path)
+    print("Post-install handler executed!")
+    print(installed_path)
+    -- print(additional)
+    return true
+end
+`
+
+func TestPostInstallHandler(t *testing.T) {
+	if l, err := ExecuteLuaScriptL(postInstallHandlerScript); err != nil {
+		t.Error(err)
+	} else {
+		postInstall := l.GetGlobal(string(PostInstall))
+		if postInstall == nil || postInstall.Type() != lua.LTFunction {
+			return
+		}
+
+		if err := l.CallByParam(lua.P{
+			Fn:      postInstall,
+			NRet:    1,
+			Protect: true,
+		}, lua.LString("/a/b/c/d/e"), lua.LString("xxx")); err != nil {
+			t.Error(err)
+			return
+		}
+
+		result := l.Get(-1)
+		assert.Equal(t, "true", result.String(), "should be 'true'")
+	}
+}

internal/luapi/plugin/plugin.go

@@ -2,6 +2,7 @@ package plugin
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 	"os"
 	"path/filepath"
@@ -125,6 +126,10 @@ func (p *Plugin) cacheFilePathForVersionList() string {
 }
 
 func (p *Plugin) loadVersionListFromCache() {
+	if cnf.GetCacheDisabled() {
+		// cache is disabled.
+		return
+	}
 	cachePath := p.cacheFilePathForVersionList()
 	if ok, _ := gutils.PathIsExist(cachePath); !ok {
 		return
@@ -260,3 +265,44 @@ func (p *Plugin) GetSDKName() (sdkName string, err error) {
 	sdkName = p.SDKName
 	return
 }
+
+type CustomedFuncFromLua func() error
+
+func (p *Plugin) getFuncFromLua(luaItem LuaConfItem, args ...string) CustomedFuncFromLua {
+	luaFunc := p.result.Lua.L.GetGlobal(string(luaItem))
+	if luaFunc == nil || luaFunc.Type() != lua.LTFunction {
+		return nil
+	}
+
+	f := func() error {
+		luaFuncArgs := make([]lua.LValue, len(args))
+		for i, arg := range args {
+			luaFuncArgs[i] = lua.LString(arg)
+		}
+
+		// if luaFuncArgs have more args than the lua function expects, the extra args will be ignored.
+		if err := p.result.Lua.L.CallByParam(lua.P{
+			Fn:      luaFunc,
+			NRet:    1,
+			Protect: true,
+		}, luaFuncArgs...); err != nil {
+			return err
+		}
+
+		result := p.result.Lua.L.Get(-1)
+		if result.String() != "true" {
+			return errors.New("post-install handler failed")
+		}
+		return nil
+	}
+	return f
+}
+
+// user can custom his/her own install method in lua plugins.
+func (p *Plugin) GetCustomedInstallHandler(args ...string) CustomedFuncFromLua {
+	return p.getFuncFromLua(CustomedInstall, args...)
+}
+
+func (p *Plugin) GetPostInstallHandler(args ...string) CustomedFuncFromLua {
+	return p.getFuncFromLua(PostInstall, args...)
+}