cleanup api defenitions on wchar* usage

Author: megai2

include/gw2al_api.h

@@ -56,7 +56,7 @@ typedef enum gw2al_log_level {
 
 typedef struct gw2al_core_vtable {
 	//converts string to hash for usage in other functions
-	gw2al_hashed_name (*hash_name)(wchar_t* name);
+	gw2al_hashed_name (*hash_name)(const wchar_t* name);
 
 	//register/unregister user functions to be called by other addons
 	gw2al_api_ret (*register_function)(void* function, gw2al_hashed_name name);
@@ -66,11 +66,11 @@ typedef struct gw2al_core_vtable {
 	void* (*query_function)(gw2al_hashed_name name);
 
 	//fills table of functions using query_function
-	void (*fill_vtable)(gw2al_hashed_name* nameList, void** vtable);
+	void (*fill_vtable)(const gw2al_hashed_name* nameList, void** vtable);
 
 	//functions to unload/load addons 
 	gw2al_api_ret (*unload_addon)(gw2al_hashed_name name);
-	gw2al_api_ret (*load_addon)(wchar_t* name);
+	gw2al_api_ret (*load_addon)(const wchar_t* name);
 
 	//function to get currently loaded addon description
 	gw2al_addon_dsc* (*query_addon)(gw2al_hashed_name name);
@@ -90,7 +90,7 @@ typedef struct gw2al_core_vtable {
 
 	//simple logging function
 
-	void (*log_text)(gw2al_log_level level, wchar_t* source, wchar_t* text);
+	void (*log_text)(gw2al_log_level level, const wchar_t* source, const wchar_t* text);
 
 } gw2al_core_vtable;
 

loader_core/gw2al_api_addon_registry.cpp

@@ -118,7 +118,7 @@ gw2al_api_ret gw2al_core__unload_addon(gw2al_hashed_name name)
 	return ret;
 }
 
-gw2al_api_ret gw2al_core__load_addon(wchar_t * name)
+gw2al_api_ret gw2al_core__load_addon(const wchar_t * name)
 {
 	LOG_DEBUG(L"core", L"Loading addon %s", name);
 

loader_core/gw2al_api_func_registry.cpp

@@ -36,7 +36,7 @@ void * gw2al_core__query_function(gw2al_hashed_name name)
 	return funcStorage.query_obj(name);
 }
 
-void gw2al_core__fill_vtable(gw2al_hashed_name * nameList, void ** vtable)
+void gw2al_core__fill_vtable(const gw2al_hashed_name * nameList, void ** vtable)
 {
 	unsigned int i = 0;
 	while (nameList[i] != 0)

loader_core/gw2al_api_impl.cpp

@@ -3,6 +3,13 @@
 FILE* logFile = NULL;
 bool firstInit = true;
 
+static const wchar_t* lvlPrefix[] = {
+	L"[INFO] ",
+	L"[ERR] ",
+	L"[WARN] ",
+	L"[DEBUG] "
+};
+
 bool gw2al_core__init()
 {
 	if (!firstInit)
@@ -18,7 +25,7 @@ bool gw2al_core__init()
 	return true;
 }
 
-gw2al_hashed_name gw2al_core__hash_name(wchar_t * name)
+gw2al_hashed_name gw2al_core__hash_name(const wchar_t * name)
 {
 	unsigned int msz = lstrlenW(name)*2;
 
@@ -53,7 +60,8 @@ void gw2al_core__client_unload()
 	}
 }
 
-void gw2al_core__log_text(gw2al_log_level level, wchar_t* source, wchar_t* text)
+
+void gw2al_core__log_text(gw2al_log_level level, const  wchar_t* source, const wchar_t* text)
 {
 #ifndef _DEBUG
 	if (level > LL_WARN)
@@ -63,13 +71,6 @@ void gw2al_core__log_text(gw2al_log_level level, wchar_t* source, wchar_t* text)
 	if (!logFile)
 		return;
 
-	static const wchar_t* lvlPrefix[] = {
-		L"[INFO] ",
-		L"[ERR] ",
-		L"[WARN] ",
-		L"[DEBUG] "
-	};
-
 	fwrite(lvlPrefix[level], sizeof(wchar_t), wcslen(lvlPrefix[level]), logFile);	
 	fwrite(source, sizeof(wchar_t), wcslen(source), logFile);
 	fwrite(L" | ", sizeof(wchar_t), 3, logFile);

loader_core/gw2al_api_impl.h

@@ -29,7 +29,7 @@ void gw2al_core__init_addon_registry();
 void gw2al_core__init_events();
 
 //converts string to hash for usage in other functions
-gw2al_hashed_name gw2al_core__hash_name(wchar_t* name);
+gw2al_hashed_name gw2al_core__hash_name(const wchar_t* name);
 
 //register/unregister user functions to be called by other addons
 gw2al_api_ret gw2al_core__register_function(void* function, gw2al_hashed_name name);
@@ -39,11 +39,11 @@ void gw2al_core__unregister_function(gw2al_hashed_name name);
 void* gw2al_core__query_function(gw2al_hashed_name name);
 
 //fills table of functions using query_function
-void gw2al_core__fill_vtable(gw2al_hashed_name* nameList, void** vtable);
+void gw2al_core__fill_vtable(const gw2al_hashed_name* nameList, void** vtable);
 
 //functions to unload/load addons 
 gw2al_api_ret gw2al_core__unload_addon(gw2al_hashed_name name);
-gw2al_api_ret gw2al_core__load_addon(wchar_t* name);
+gw2al_api_ret gw2al_core__load_addon(const wchar_t* name);
 
 //function to get currently loaded addon description
 gw2al_addon_dsc* gw2al_core__query_addon(gw2al_hashed_name name);
@@ -59,4 +59,4 @@ unsigned int gw2al_core__trigger_event(gw2al_event_id id, void* data);
 
 void gw2al_core__client_unload();
 
-void gw2al_core__log_text(gw2al_log_level level, wchar_t* source, wchar_t* text);
+void gw2al_core__log_text(gw2al_log_level level, const wchar_t* source, const wchar_t* text);