Bugfix for multi-launch UI freezes (Closes #941) (#943)

Author: AlexMacocian

Daybreak/Controls/Templates/LaunchButtonTemplate.xaml.cs

@@ -131,7 +131,8 @@ private async Task CheckGameState(CancellationToken cancellationToken)
         }
 
         // If FocusView is disabled, don't initialize memory scanner, instead just allow the user to kill the game
-        if (!this.liveOptions.Value.Enabled)
+        if (!this.liveOptions.Value.Enabled ||
+            !launcherViewContext.IsSelected)
         {
             this.GameRunning = false;
             this.CanLaunch = false;

Daybreak/Models/LauncherViewContext.cs

@@ -4,30 +4,37 @@
 namespace Daybreak.Models;
 public sealed class LauncherViewContext : INotifyPropertyChanged
 {
-    private bool canLaunch = false;
-    private bool canKill = false;
-
     public event PropertyChangedEventHandler? PropertyChanged;
 
     public LaunchConfigurationWithCredentials? Configuration { get; init; }
 
+    public bool IsSelected
+    {
+        get;
+        set
+        {
+            field = value;
+            this.PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(nameof(this.IsSelected)));
+        }
+    } = false;
+
     public bool CanLaunch
     {
-        get => this.canLaunch;
+        get;
         set
         {
-            this.canLaunch = value;
+            field = value;
             this.PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(nameof(this.CanLaunch)));
         }
-    }
+    } = false;
 
     public bool CanKill
     {
-        get => this.canKill;
+        get;
         set
         {
-            this.canKill = value;
+            field = value;
             this.PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(nameof(this.CanKill)));
         }
-    }
+    } = false;
 }

Daybreak/Services/Scanner/GuildwarsMemoryReader.cs

@@ -20,18 +20,15 @@
 namespace Daybreak.Services.Scanner;
 
 public sealed class GuildwarsMemoryReader(
-    IApplicationLauncher applicationLauncher,
     IMemoryScanner memoryScanner,
     IMetricsService metricsService,
     ILogger<GuildwarsMemoryReader> logger) : IGuildwarsMemoryReader
 {
-    private const int MaxTrapezoidCount = 1000000;
     private const int RetryInitializationCount = 5;
     private const string LatencyMeterName = "Memory Reader Latency";
     private const string LatencyMeterUnitsName = "Milliseconds";
     private const string LatencyMeterDescription = "Amount of milliseconds elapsed while reading memory. P95 aggregation";
 
-    private readonly IApplicationLauncher applicationLauncher = applicationLauncher.ThrowIfNull();
     private readonly IMemoryScanner memoryScanner = memoryScanner.ThrowIfNull();
     private readonly Histogram<double> latencyMeter = metricsService.ThrowIfNull().CreateHistogram<double>(LatencyMeterName, LatencyMeterUnitsName, LatencyMeterDescription, AggregationTypes.P95);
     private readonly ILogger<GuildwarsMemoryReader> logger = logger.ThrowIfNull();
@@ -745,10 +742,10 @@ private static PlayerInformation GetPlayerInformation(
                 Primary = primaryProfession,
                 Secondary = secondaryProfession,
                 Attributes = attributes,
-                Skills = skillContexts.Select(s =>
+                Skills = [.. skillContexts.Select(s =>
                         Skill.TryParse((int)s.Id, out var parsedSkill) ?
                         parsedSkill :
-                        Skill.NoSkill).ToList()
+                        Skill.NoSkill)]
             };
         }
 

Daybreak/Views/LauncherView.xaml.cs

@@ -189,7 +189,16 @@ private async Task SetLaunchButtonState()
             return;
         }
 
-        await this.Dispatcher.InvokeAsync(() => this.CanLaunch = this.LatestConfiguration.CanLaunch);
+        await this.Dispatcher.InvokeAsync(() =>
+        {
+            foreach (var config in this.LaunchConfigurations)
+            {
+                config.IsSelected = false;
+            }
+
+            this.LatestConfiguration.IsSelected = true;
+            this.CanLaunch = this.LatestConfiguration.CanLaunch;
+        });
     }
 
     private async Task KillGuildWars()