-
Notifications
You must be signed in to change notification settings - Fork 14
Correct installation and import of packages #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Also remove useless matplotlib options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it on Collab and even though the error message appears, the whole notebook runs just fine.
|
Thank you. Maybe we can mention the error message in the notebook (precising that it should work). |
I added a basic message in 31d4dbe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the text change suggestion, I think it looks good.
| "metadata": {}, | ||
| "source": [ | ||
| "Some packages may be missing on some platforms so we try to install them (you may see error messages when running on Google Colab but installation usually works).\n", | ||
| "If you experience problems, please [fill in an issue](https://github.com/gwosc-tutorial/quickview/issues)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "please file an issue" or "please report an issue" or "please fill out an issue form" would be better.
This PR fixes #7 by changing the code to install packages.
The main idea is to install gwpy 3.0.13. This version is compatible with recent matlplotlib versions used on Colab. Tests show that it's not needed to explicitly install
matplotlibandastropy(they are installed as pre-requisites ofgwpy).To smoothen usage inside and outside Colab:
matplotlibafter ensuring the presence ofgwpy.This works in a minimal virtual/conda env and on Colab.
Closes #7.