Update to latest gwt/elemental2 and enable j2cl tests in build

Author: niloc132

gwt-core-gwt2-tests/pom.xml

@@ -57,7 +57,7 @@
         <maven.licence.plugin>3.0</maven.licence.plugin>
         <maven.source.plugin>3.1.0</maven.source.plugin>
 
-        <gwt.version>2.8.2</gwt.version>
+        <gwt.version>2.9.0</gwt.version>
         <junit.version>4.12</junit.version>
     </properties>
 

gwt-core-j2cl-tests/pom.xml

@@ -61,8 +61,6 @@
         <vertispan.j2cl.repo.url>https://repo.vertispan.com/j2cl/</vertispan.j2cl.repo.url>
         <google.snapshot.repo.url>https://oss.sonatype.org/content/repositories/google-snapshots/</google.snapshot.repo.url>
 
-<!--        <elemental2.version>1.0.0-RC1</elemental2.version>-->
-        <jsinterop.base.version>1.0.0-SNAPSHOT</jsinterop.base.version>
         <j2cl.version>0.7-SNAPSHOT</j2cl.version>
         <slf4j.version>1.7.5</slf4j.version>
     </properties>
@@ -130,6 +128,7 @@
                 <executions>
                     <execution>
                         <id>j2cl-test</id>
+                        <phase>test</phase>
                         <goals>
                             <goal>test</goal>
                         </goals>

gwt-core-j2cl-tests/src/test/java/org/gwtproject/core/client/ScriptInjectorTest.java

@@ -527,14 +527,14 @@ private Window topWindow() {
   };
 
   private Document getDocumentFromWindow(JavaScriptObject wnd) {
-    return Js.<JsPropertyMap<Any>>cast(wnd).getAny("document").cast();
+    return Js.<JsPropertyMap<Any>>cast(wnd).getAsAny("document").cast();
   }
 
   /** @return URL of test base path */
   private String getTestBasePath() {
 
     // TODO This is more a hack and should be improved!
-    final String href = DomGlobal.location.getHref();
+    final String href = DomGlobal.location.href;
     final String basePath = href.substring(0, href.lastIndexOf("/") + 1);
 
     return basePath;

gwt-core/pom.xml

@@ -52,7 +52,7 @@
         <maven.source.plugin>3.2.1</maven.source.plugin>
         <maven.deploy.plugin>3.0.0-M1</maven.deploy.plugin>
 
-        <elemental2.version>1.0.0-RC1</elemental2.version>
+        <elemental2.version>1.0.0</elemental2.version>
     </properties>
 
     <dependencies>

gwt-core/src/main/java/org/gwtproject/core/client/JsArrayMixed.java

@@ -49,7 +49,7 @@ protected JsArrayMixed() {}
    */
   @JsOverlay
   public final boolean getBoolean(int index) {
-    return Js.isTruthy(this.<JsArray<Object>>cast().getAnyAt(index));
+    return Js.isTruthy(this.<JsArray<Object>>cast().getAtAsAny(index));
   }
 
   /**
@@ -60,7 +60,7 @@ public final boolean getBoolean(int index) {
    */
   @JsOverlay
   public final double getNumber(int index) {
-    return Js.coerceToDouble(this.<JsArray<Object>>cast().getAnyAt(index));
+    return Js.coerceToDouble(this.<JsArray<Object>>cast().getAtAsAny(index));
   }
 
   /**
@@ -72,7 +72,7 @@ public final double getNumber(int index) {
   @JsOverlay
   public final <T extends JavaScriptObject> T getObject(int index) {
     return this.<JsArray<Object>>cast().getAt(index) != null
-        ? this.<JsArray<Object>>cast().getAnyAt(index).cast()
+        ? this.<JsArray<Object>>cast().getAtAsAny(index).<T>cast()
         : null;
   }
 

gwt-core/src/main/java/org/gwtproject/core/client/ScriptInjector.java

@@ -52,7 +52,7 @@ public JavaScriptObject inject() {
       assert wnd != null;
       Document doc =
           Js.<JsPropertyMap<Any>>uncheckedCast(wnd)
-              .getAny("document")
+              .getAsAny("document")
               .uncheckedCast(); // window has no document property... TODO
       assert doc != null;
 
@@ -116,7 +116,7 @@ public JavaScriptObject inject() {
       assert wnd != null;
       Document doc =
           Js.<JsPropertyMap<Any>>uncheckedCast(wnd)
-              .getAny("document")
+              .getAsAny("document")
               .uncheckedCast(); // window has no document property... TODO
       assert doc != null;
 
@@ -237,7 +237,6 @@ private static void attachListeners(
           if (removeTag) {
             scriptElement.parentNode.removeChild(scriptElement);
           }
-          return null;
         };
     // or possibly more portable script_tag.addEventListener('error', function(){...}, true);
     scriptElement.onerror =